Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($core): transpile all core js (#1623) #1685

Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix($core): transpile all core js (#1623) #1685

merged 1 commit into from
Jul 29, 2019

Conversation

massimosiani
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 75
  • Firefox 67
  • Safari 12.1.1
  • Edge 34
  • IE 10 + 11

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
My use case only needs that the generated js code is transpiled to es5 to make my components compatible with ie. Feel free to close this PR and open a better one (I really need it tough :)).

@massimosiani massimosiani changed the title fix(): transpile all core js (#1623) fix($core): transpile all core js (#1623) Jul 3, 2019
@ulivz ulivz merged commit 6460b0c into vuejs:master Jul 29, 2019
@vue-bot
Copy link

vue-bot commented Jul 29, 2019

Hey @massimosiani, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants