Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bitbucket server in Edit Link #2043

Open
RecuencoJones opened this issue Nov 28, 2019 · 0 comments
Open

Support for Bitbucket server in Edit Link #2043

RecuencoJones opened this issue Nov 28, 2019 · 0 comments
Labels
type: feature request Request to add a new feature type: question or discussion Question or discussion

Comments

@RecuencoJones
Copy link

Feature request

What problem does this feature solve?

From what I've seen in #1235, bitbucket cloud is now supported. However, bitbucket server uses a different format for the repository URL, it would be great to support this as well.

What does the proposed API look like?

In themeConfig, we could have something like this:

themeConfig: 
  docsRepo: bitbucket server # Match with a regex like /bitbucket.*server/i
  bitbucketServerRepo: https://my.bitbucket.server/projects/awesome/repos/documentation

How should this be implemented in your opinion?

I've tested so far the following changes PageEdit.vue:

https://github.com/RecuencoJones/vuepress/blob/c13b271bcd7d19049124ebcd2320c48585c45b45/packages/%40vuepress/theme-default/components/PageEdit.vue#L84-L94

Are you willing to work on this yourself?

Sure!

@kefranabg kefranabg added type: feature request Request to add a new feature type: question or discussion Question or discussion labels Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request Request to add a new feature type: question or discussion Question or discussion
Projects
None yet
Development

No branches or pull requests

2 participants