Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese title in sidebar is not properly highlighted after refresh #2078

Closed
1 task done
huiminxu opened this issue Dec 12, 2019 · 3 comments · Fixed by #2166 · May be fixed by adamlaska/osmos-cosmos-sdk#5
Closed
1 task done

Chinese title in sidebar is not properly highlighted after refresh #2078

huiminxu opened this issue Dec 12, 2019 · 3 comments · Fixed by #2166 · May be fixed by adamlaska/osmos-cosmos-sdk#5
Labels
contribution welcome Contributions welcome type: bug Something isn't working

Comments

@huiminxu
Copy link

huiminxu commented Dec 12, 2019

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

Bug:When the address bar refreshes the page, the left side is no longer selected

What is expected?

Expected: When the address bar refreshes the page, the left side is selected

What is actually happening?

image
image

Other relevant information

  • Output of npx vuepress info in my VuePress project:
@haoranpb
Copy link
Contributor

Hi @huiminxu ,

Can you provide more detail about how to reproduce this problem? or a minimal reproduction?

@huiminxu
Copy link
Author

huiminxu commented Dec 13, 2019

@ludanxer When developing a page, the menu bar on the left shows the secondary title, click on a title, the right side of the display the contents of the title, the selected color on the left and the address bar is # 2 titles 。but refreshed in the address bar , the right still can display the contents of the corresponding title, but not on the left side of the selected state

@haoranpb
Copy link
Contributor

Thanks a lot, this is also happening on the official website.

I think this problem is happening whenever the URL contains Chinese characters. Try this Chinese translation, when you open the page, the title in the sidebar is not highlighted with green. When you click on the 基本配置 in the sidebar, it's highlighted but after refreshing the page, the highlight is gone again.

And the English site is giving the expected behavior.

@huiminxu Can you rename the issue's title to something like Chinese title in sidebar is not properly highlighted after refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome type: bug Something isn't working
Projects
None yet
3 participants