Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Theme NavBar Links Not Displayed Correctly on Mobile View #359

Closed
raytu opened this issue May 7, 2018 · 8 comments
Closed

Default Theme NavBar Links Not Displayed Correctly on Mobile View #359

raytu opened this issue May 7, 2018 · 8 comments

Comments

@raytu
Copy link

raytu commented May 7, 2018

VuePress version: 0.8.4

Hi,

I notice that the NavBar dropdown links get wrapped and overlayed with the following links in mobile/vertical view. Please have a look at the attached screenshots to see what I mean. Thanks!

Desktop Screenshot:
image

Mobile Screenshot (Issue in the Teaching submenu):
image

@ycmjason
Copy link
Contributor

ycmjason commented May 7, 2018

Could you please kindly include a reproduction link? This would really help investigating the issue.

@raytu
Copy link
Author

raytu commented May 7, 2018

Link: http://huahongtu.me

@ycmjason
Copy link
Contributor

ycmjason commented May 7, 2018

@raytu thank you. And the source❓

@raytu
Copy link
Author

raytu commented May 7, 2018

module.exports = {
  themeConfig: {
    nav: [
      { text: 'Home', link: '/' },
      { 
        text: 'Teaching',
        **items: [
          { text: 'FIRE171: Capital One Machine Learning', link: '/teaching/fire171-s18/' },
          { text: 'FIRE271: Capital One Machine Learning', link: '/teaching/fire271-f18/' }
        ]**
      },
      { text: 'Research', link: '/research/' },
      { text: 'Publications', link: '/publications/' },
      { text: 'Media', link: '/media/' },
      { text: 'CV', link: '/cv/' }
    ]
  }
}

@ycmjason
Copy link
Contributor

ycmjason commented May 7, 2018

@raytu

Fixed at #360

@ycmjason
Copy link
Contributor

ycmjason commented May 7, 2018

@raytu you could make the changes in #360 to temporarily fix the issue.

@raytu
Copy link
Author

raytu commented May 7, 2018

Thanks! I'm surprised that you fixed it so fast. Will this fix be put in the next VuePress version?

@ycmjason
Copy link
Contributor

ycmjason commented May 7, 2018

@raytu No worries! 😄
If this will be released in the next version depends if they approve my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants