Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog plugin blocking front matter custom layout config #906

Closed
mAKEkr opened this issue Oct 6, 2018 · 3 comments
Closed

Blog plugin blocking front matter custom layout config #906

mAKEkr opened this issue Oct 6, 2018 · 3 comments

Comments

@mAKEkr
Copy link
Contributor

mAKEkr commented Oct 6, 2018 •
edited
Loading

Bug report

Version

v1.0.0-alpha.4

Steps to reproduce

  1. add new markdown file
  2. configure front matter layout: specialLayout
  3. check markdown file in dev, production result

What is expected?

displaying custom component in .vuepress/component/specialLayout.vue

What is actually happening?

displaying Page component in vuepress theme.

Other relevant information

  • Your OS: Windows 10
  • Node.js version: 10.11.0
  • Browser version: Firefox 62.0.3(x64)
  • Is this a global or local install? local
  • Which package manager did you use for the install? yarn
@seifertm
Copy link
Contributor

I can reproduce the issue with v1.0.0-alpha.20 as well.

@bin16
Copy link
Contributor

bin16 commented Nov 19, 2018

See:

vuepress/packages/@vuepress/plugin-blog/index.js

Line 67 in 59eaa6a

Object.assign(rawFrontmatter, frontmatter)

frontmatter contains default values(permalink and layout), and rawFrontmatter is from markdown file, so...

@bin16 bin16 mentioned this issue Nov 19, 2018
Closed
18 tasks
bin16 added a commit to bin16/vuepress that referenced this issue Nov 19, 2018
@bin16
fix vuejs#906 : Blog plugin blocking front matter custom layout confi…
db88a55 
…g - cp attrs from default to raw frontmatters, if not exists
@bin16 bin16 mentioned this issue Nov 19, 2018
Merged
18 tasks
@ulivz ulivz closed this as completed in ab0e002 Nov 20, 2018
@lei-cao
Copy link

lei-cao commented Jan 28, 2019

seems it's broken in 1.0.0-alpha.33 again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lei-cao @mAKEkr @seifertm @bin16