Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($core): assert object return type for functional plugin #1516

Merged
merged 2 commits into from
Apr 6, 2019

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Apr 3, 2019

Summary

// vuepress-plugin-foo.js
module.exports = () => {}

VuePress should show error and fallback to {} when confronted with such situations.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

N/A

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@shigma shigma changed the title fix($core): assert object type for functional plugin fix($core): assert object return type for functional plugin Apr 3, 2019
@ulivz
Copy link
Member

ulivz commented Apr 6, 2019

Maybe it should be a feature.

@ulivz ulivz merged commit 74887c5 into master Apr 6, 2019
@ulivz ulivz deleted the check-plugin-callback-type branch June 4, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants