feat($theme-default): support configuring target and rel for nav links (close #1353) #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozero
approved these changes
Sep 5, 2019
|
Hello @newsbielt703 thank's for the PR ! I am waiting for others approval and we will merge it |
flozero
added
topic: config
kefranabg
requested changes
Sep 20, 2019
There was a problem hiding this comment.
Hey @newsbielt703,
If a link is considered as an internal link, adding `target: '_blank' is not working.
For example, in the official VP documentation in .vuepress/nav/en.js :
{
text: 'Guide',
link: '/guide/',
target: '_blank',
}
This will not make the guide page open in a new tab.
billyyyyy3320
force-pushed
the
feat/default_theme_external_link
branch
from
389c576 to
377da36
Compare
billyyyyy3320
force-pushed
the
feat/default_theme_external_link
branch
from
377da36 to
9eee190
Compare
billyyyyy3320
changed the title
|
@kefranabg Thanks for your suggestion. |
ulivz
reviewed
Oct 11, 2019
billyyyyy3320
changed the title
billyyyyy3320
changed the title
kefranabg
approved these changes
Oct 16, 2019
|
Hey @newsbielt703, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1353
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: