Skip to content

docs: Put yarn in front of npm #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 3, 2019
Merged

docs: Put yarn in front of npm #1968

merged 6 commits into from
Dec 3, 2019

Conversation

haoranpb
Copy link
Contributor

Summary

Ref: #1936 #1286

If you think this is a good idea, I will finish the corresponding Chinese document.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Sun Haoran and others added 2 commits November 14, 2019 10:20
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
@haoranpb
Copy link
Contributor Author

Chinese translation is done.

@meteorlxy
Copy link
Member

I'm not sure if it's necessary to change the deploying guide.

It seems that a warning tip in the plugin guide is enough?

@haoranpb
Copy link
Contributor Author

Actually, I'm not very sure either.

But I think it would be a little more user-friendly for beginners and easier to copy and paste?

@meteorlxy meteorlxy merged commit a90b24a into vuejs:master Dec 3, 2019
@vue-bot
Copy link

vue-bot commented Dec 3, 2019

Hey @ludanxer, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@haoranpb haoranpb deleted the docs-yarn-npm branch December 3, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants