Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #653 #657

Merged
merged 1 commit into from Jul 22, 2018

Conversation

@jordonbaade
Copy link
Contributor

commented Jul 17, 2018

Summary

Fixes: #653

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
I didn't test but I didn't think there was much to it. If you need more, please let me know; I'm new! 馃槃

@ulivz ulivz merged commit 9b602f2 into vuejs:master Jul 22, 2018

1 check passed

deploy/netlify Deploy preview ready!
Details

LinFeng1997 added a commit to docschina/vuepress that referenced this pull request Aug 4, 2018

缈昏瘧service worker 閮ㄥ垎 (#20)
* chore: remove override.styl

* refactor: changelog

* feat: transform Badge into async component

* fix: set babelrc: false in babel-loader options (vuejs#644)

Prevents picking up local `.babelrc` file in projects.

* docs($cn): update for new file-level API: style.styl.

* feat($pwa): add themeConfig.serviceWorker.updatePopup option (close: vuejs#453) (vuejs#533)

* docs: tweaks

* docs: enable serviceWorker.updatePopup

* chore: update register-service-worker to latest

* docs($cn): tweaks (vuejs#652)

* refactor($release): let [enter] pass next step (vuejs#650)

* chore: fix code snippet typo (missing semi-colon) (vuejs#658)

* docs: tweaks lastUpdated (vuejs#663)

* fix: scoped styles of badge component (close: vuejs#653) (vuejs#657)

* fix($build): markdown config should be included in cache identifier

It's reported by vuejs#664, but vuejs#664 cannot be fixed fully since watching webpack config changes shouldn't be handled in VuePresss

VuePress can only ensure that when user changes the markdown config, the cache identifier will be updated, so user needn't to clean the ./node_modules/.cache manually.

See: webpack/webpack#3153, webpack/webpack-cli#15

* workflow: update issue template - add more guidelines

* feat($cli): debug flag at dev mode

reason for this feature: webpack-bar will wipe out the debug log at dev mode.

* fix($seo): Avoid duplicate description meta at runtime. (close: vuejs#665)

* refactor: code style

Follow the official code style guide, refs:

1. https://vuejs.org/v2/style-guide/#Multi-attribute-elements-strongly-recommended
2. https://vuejs.org/v2/style-guide/#Empty-lines-in-component-instance-options-recommend
3. https://github.com/vuejs/ui

* fix($markdown): cannot highlight external python file (.py) correctly (close: vuejs#660)

* fix: missing space between italics and bold (close: vuejs#661)

"markdown-it" will intendedly reserve this space, and this issue was caused by "preserveWhitespace: true" (See: https://github.com/vuejs/vue/tree/dev/packages/vue-template-compiler#options),

Impact on performance (Size of whole assets): Before (1952K), After (1960K), which is an acceptable change.

* chore: add alt attribute to logo image (vuejs#672)

* fix($build): exclude dest folder from pageFiles (close: vuejs#654) (vuejs#655)

* refactor: naming and comments (vuejs#655)

* chore: update deps

* test: fix SecurityError: localStorage is not available for opaque origins

ref: facebook/jest#6769

* 0.13.0

* chore: changelog

* chore: enhance changelog

* docs: i18n for serviceWorker.updatePopup

* docs($cn): document for themeConfig.serviceWorker.updatePopup

* chore: changelog

* docs: update reamde - add SW-update popup

* docs: document i18n example for SW-update popup

* docs: document beta status for SW-update popup

ref: vuejs#677

* fix: py lang label doesn't display in code block (vuejs#690)

* fix: normalize override file path in windows (vuejs#692) (close: vuejs#642)

* 0.13.1

* chore: changelog

* 鎻愪氦first缈昏瘧

LinFeng1997 added a commit to docschina/vuepress that referenced this pull request Aug 12, 2018

Translate to v0.14.1 (#22)
* feat: control BundleRenderer shouldPrefetch option (vuejs#463)

* chore: remove override.styl

* refactor: changelog

* feat: transform Badge into async component

* fix: set babelrc: false in babel-loader options (vuejs#644)

Prevents picking up local `.babelrc` file in projects.

* docs($cn): update for new file-level API: style.styl.

* Translate to v0.12.0

* feat($pwa): add themeConfig.serviceWorker.updatePopup option (close: vuejs#453) (vuejs#533)

* docs: tweaks

* docs: enable serviceWorker.updatePopup

* chore: update register-service-worker to latest

* docs($cn): tweaks (vuejs#652)

* refactor($release): let [enter] pass next step (vuejs#650)

* chore: fix code snippet typo (missing semi-colon) (vuejs#658)

* docs: tweaks lastUpdated (vuejs#663)

* fix: scoped styles of badge component (close: vuejs#653) (vuejs#657)

* fix($build): markdown config should be included in cache identifier

It's reported by vuejs#664, but vuejs#664 cannot be fixed fully since watching webpack config changes shouldn't be handled in VuePresss

VuePress can only ensure that when user changes the markdown config, the cache identifier will be updated, so user needn't to clean the ./node_modules/.cache manually.

See: webpack/webpack#3153, webpack/webpack-cli#15

* workflow: update issue template - add more guidelines

* feat($cli): debug flag at dev mode

reason for this feature: webpack-bar will wipe out the debug log at dev mode.

* fix($seo): Avoid duplicate description meta at runtime. (close: vuejs#665)

* refactor: code style

Follow the official code style guide, refs:

1. https://vuejs.org/v2/style-guide/#Multi-attribute-elements-strongly-recommended
2. https://vuejs.org/v2/style-guide/#Empty-lines-in-component-instance-options-recommend
3. https://github.com/vuejs/ui

* fix($markdown): cannot highlight external python file (.py) correctly (close: vuejs#660)

* fix: missing space between italics and bold (close: vuejs#661)

"markdown-it" will intendedly reserve this space, and this issue was caused by "preserveWhitespace: true" (See: https://github.com/vuejs/vue/tree/dev/packages/vue-template-compiler#options),

Impact on performance (Size of whole assets): Before (1952K), After (1960K), which is an acceptable change.

* chore: add alt attribute to logo image (vuejs#672)

* fix($build): exclude dest folder from pageFiles (close: vuejs#654) (vuejs#655)

* refactor: naming and comments (vuejs#655)

* chore: update deps

* test: fix SecurityError: localStorage is not available for opaque origins

ref: facebook/jest#6769

* 0.13.0

* chore: changelog

* chore: enhance changelog

* docs: i18n for serviceWorker.updatePopup

* docs($cn): document for themeConfig.serviceWorker.updatePopup

* chore: changelog

* docs: update reamde - add SW-update popup

* docs: document i18n example for SW-update popup

* docs: document beta status for SW-update popup

ref: vuejs#677

* fix: py lang label doesn't display in code block (vuejs#690)

* fix: normalize override file path in windows (vuejs#692) (close: vuejs#642)

* 0.13.1

* chore: changelog

* fix: set alias "collapsible" to "collapsable" (close: vuejs#705) (vuejs#706)

* docs: enhance docSearch integration with language (vuejs#697)

* Revert "docs: enhance docSearch integration with language (vuejs#697)"

This reverts commit 0d581c4.

* fix: algolia search doesn't work well at i18n mode

Add lang facetFilters presets by following VuePress's i18n design logic

* docs: enable algolia docsearch for vuepress

* chore: update sponsor image

* chore: generalized support for code highlighting (vuejs#696)

* feat: support writing HTML(Vue) anywhere in the header. (vuejs#711)

1. You can write HTML(Vue) anywhere in the header as long as it is not wrapped by code(`).
2. The HTML wrapped by code will be shown as it is.
3. A good practice when using HTML in a header is to leave a space between plain text and HTML.

* chore: bump theme

* docs: fix typo

* docs: update docs

* docs: docuement using components in headers

* feat($webpack): display host url at dev HMR log

* fix: skip format data.head if not exist while loading toml config (vuejs#707)

* fix: navbar's messy layout at narrow screen (vuejs#714)

* docs: tweaks

* 0.14.0

* chore: changelog

* refactor: changelog

* fix: default search box line wrap

* fix: navbar's regression - siteName null check

* ci: add npm whoami

* 0.14.1

* chore: changelog

* trans锛歷0.14.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.