Skip to content

fix: Google Analytics Plugin build error #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2018
Merged

fix: Google Analytics Plugin build error #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9cdc49
Update README.md
mAKEkr Sep 30, 2018
ca618e4
fix on build progressing displaying error
mAKEkr Sep 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-google-analytics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
### ga

- Type: `string`
- Default: `/i18n/`
- Default: `undefined`

Provide the Google Analytics ID to enable integration.
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-google-analytics/inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

export default ({ router }) => {
// Google analytics integration
if (process.env.NODE_ENV === 'production' && GA_ID) {
if (process.env.NODE_ENV === 'production' && GA_ID && typeof window !== 'undefined') {
(function (i, s, o, g, r, a, m) {
i['GoogleAnalyticsObject'] = r
i[r] = i[r] || function () {
Expand Down