Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make obvious where to import store from #1687

Merged
merged 2 commits into from Mar 11, 2020
Merged

docs: make obvious where to import store from #1687

merged 2 commits into from Mar 11, 2020

Conversation

@elevatebart
Copy link
Contributor

elevatebart commented Mar 2, 2020

As we browse through the modules page, it is unclear where the store is imported from.

Since it is a one liner, I thought it would clarify to have the import explicitly here.

Tell me what you think.

As we browse through the modules page, it is unclear where the `store` is imported from.

Since it is a one liner, I thought it would clarify to have the import explicitly here.

Tell me what you think.
@ktsn

This comment has been minimized.

Copy link
Member

ktsn commented Mar 3, 2020

You can't import store from vuex as it is an instance object which you create by new Vuex.Store and where users import from may be different between users.

@elevatebart

This comment has been minimized.

Copy link
Contributor Author

elevatebart commented Mar 3, 2020

Thank you @ktsn.
I did not know that,
Do you think it is useful that I try to clarify it somewhere?

docs/guide/modules.md Outdated Show resolved Hide resolved
@kiaking kiaking added the docs label Mar 3, 2020
@kiaking

This comment has been minimized.

Copy link
Member

kiaking commented Mar 10, 2020

@elevatebart Hi! How is't going? Would it be possible for you to update the docs including comment from ktsn?

Co-Authored-By: Katashin <ktsn55@gmail.com>
@elevatebart

This comment has been minimized.

Copy link
Contributor Author

elevatebart commented Mar 10, 2020

御免なさい...

(^^;)

@kiaking

This comment has been minimized.

Copy link
Member

kiaking commented Mar 11, 2020

Thanks! Looking good to me. What do you say @ktsn ?

@ktsn
ktsn approved these changes Mar 11, 2020
Copy link
Member

ktsn left a comment

Looks good. Thank you!

@ktsn ktsn merged commit 4d7f390 into vuejs:dev Mar 11, 2020
6 checks passed
6 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
sthagen added a commit to sthagen/vuex that referenced this pull request Mar 12, 2020
docs: make obvious where the store come from (vuejs#1687)
andrewminer added a commit to andrewminer/vuex that referenced this pull request Mar 19, 2020
* docs: make obvious where to import store from

As we browse through the modules page, it is unclear where the `store` is imported from.

Since it is a one liner, I thought it would clarify to have the import explicitly here.

Tell me what you think.

* docs: import vuex instead of store

Co-Authored-By: Katashin <ktsn55@gmail.com>

Co-authored-by: Katashin <ktsn55@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.