Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Conversation

@natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented Jan 28, 2025

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-1x#4327

Proposed changes

How to test

vyos@vyos# ls /sys/class/net/
dum0  eth0  eth1  eth2  eth3  lo  pim6reg
[edit]
vyos@vyos# set vpp settings interface dum0

  Error: dum0 is not an ehternet interface



  Invalid interface name
  Value validation failed
  Set failed

[edit]
vyos@vyos# set vpp settings interface eth99

  Error: eth99 does not exist in the system



  Invalid interface name
  Value validation failed
  Set failed

[edit]
vyos@vyos# set vpp settings interface eth1
[edit]
vyos@vyos#

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@natali-rs1985 natali-rs1985 changed the title T7076: VPP check ethernet interface exist before adding to vpp T7076: VPP check ethernet interface exist Jan 30, 2025
Copy link
Contributor

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit the constaint to only allow ethernet interfaces.

@natali-rs1985
Copy link
Contributor Author

Please limit the constaint to only allow ethernet interfaces.

Done

@sever-sever sever-sever merged commit 71875be into vyos-legacy:current Feb 3, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants