-
Notifications
You must be signed in to change notification settings - Fork 137
fields in abort() Update paymentrequest.html #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<p>The <code><dfn>abort</dfn></code> method may be called if the web page wishes to abort the payment | ||
request after the <a><code>show</code></a> method has been called and before the [[\acceptPromise]] | ||
request after the <a><code>show</code></a> method has been called and before the <em>request</em>[[\acceptPromise]] | ||
has been resolved.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to <em>request</em>@[[\acceptPromise]]
If you're going to use the format object@[[slotname]] then you have to define the object. |
@adrianba, does that imply changing: <p>The <code><dfn>abort</dfn></code> method may be called if the web page
wishes to abort the payment request (<var>request</var>) after the
<a><code>show</code></a> method has been called and before the
<em>request</em>@[[\acceptPromise]] has been resolved.</p> to <p>The <code><dfn>abort</dfn></code> method may be called if the web page
wishes to abort the payment request after the <a><code>show</code></a>
method has been called and before the <em>request</em>@[[\acceptPromise]] has
been resolved.</p> or something similar? |
I think you have the from and to backwards, which confused me, but yes, something like this defining the variable request before using it. |
@adrianba you are right, sorry! |
Copied "Let request be the |
LGTM |
Merged as 894ada9 |
Hi,
https://cdn.rawgit.com/w3c/browser-payment-api/0d1d5d7ff0f1bb7b37970994f1eb719101aaccbc/fpwd/paymentrequest.html#abort
I think that “ [[“ should be replaced by “request@[[“ in this section.
E.g.: “If the value of [[state]] is not interactive then throw an InvalidStateError.” Should be “If the value of request@[[state]] is not interactive then throw an InvalidStateError.”
Kind regards
Axel
The default branch is gh-pages but my understanding of how w3c specs at github work is that gh-pages should not be touched by humans.