Skip to content

Conversation

AxelNennker
Copy link
Contributor

Hi,
https://cdn.rawgit.com/w3c/browser-payment-api/0d1d5d7ff0f1bb7b37970994f1eb719101aaccbc/fpwd/paymentrequest.html#abort

I think that “ [[“ should be replaced by “request@[[“ in this section.
E.g.: “If the value of [[state]] is not interactive then throw an InvalidStateError.” Should be “If the value of request@[[state]] is not interactive then throw an InvalidStateError.”

Kind regards
Axel

The default branch is gh-pages but my understanding of how w3c specs at github work is that gh-pages should not be touched by humans.

<p>The <code><dfn>abort</dfn></code> method may be called if the web page wishes to abort the payment
request after the <a><code>show</code></a> method has been called and before the [[\acceptPromise]]
request after the <a><code>show</code></a> method has been called and before the <em>request</em>[[\acceptPromise]]
has been resolved.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to <em>request</em>@[[\acceptPromise]]

@adrianba
Copy link
Contributor

If you're going to use the format object@[[slotname]] then you have to define the object.

@adrianhopebailie
Copy link
Collaborator

@adrianba, does that imply changing:

<p>The <code><dfn>abort</dfn></code> method may be called if the web page 
wishes to abort the payment request (<var>request</var>) after the 
<a><code>show</code></a> method has been called and before the 
<em>request</em>@[[\acceptPromise]] has been resolved.</p>

to

<p>The <code><dfn>abort</dfn></code> method may be called if the web page 
wishes to abort the payment request after the <a><code>show</code></a> 
method has been called and before the <em>request</em>@[[\acceptPromise]] has 
been resolved.</p>

or something similar?

@adrianba
Copy link
Contributor

I think you have the from and to backwards, which confused me, but yes, something like this defining the variable request before using it.

@adrianhopebailie
Copy link
Collaborator

@adrianba you are right, sorry!
@AxelNennker can you update your PR to incorporate the suggested changes?

@AxelNennker
Copy link
Contributor Author

Copied "Let request be the PaymentRequest object on which the method is called." from a previous section and inserted it into this one.

@adrianhopebailie
Copy link
Collaborator

LGTM

@adrianba
Copy link
Contributor

Merged as 894ada9

@adrianba adrianba closed this Apr 19, 2016
@adrianhopebailie adrianhopebailie modified the milestone: Priority: Low Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants