Remove id attribute from PaymentItem #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaymentItems are only used for display and we don't currently have a reason to provide an id. Since this is a dictionary, developers can add whatever fields they want but _requiring_ an ID is unnecessary.
|
Sounds good to me |
|
LGTM |
adrianba
added a commit
to adrianba/browser-payment-api
that referenced
this pull request
Apr 28, 2016
PRs w3c#158, w3c#160, and w3c#161 made changes that affect the examples. These weren't reflected in original PRs to keep those changes simple and to avoid merge conflicts from changing the same lines in the spec. This changes updates the examples. Also updating the syntax to be consistent and use JavaScript (rather than JSON). Fixes w3c#164.
adrianba
added a commit
that referenced
this pull request
Apr 28, 2016
PRs #158, #160, and #161 made changes that affect the examples. These weren't reflected in original PRs to keep those changes simple and to avoid merge conflicts from changing the same lines in the spec. This changes updates the examples. Also updating the syntax to be consistent and use JavaScript (rather than JSON). Fixes #164.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaymentItems are only used for display and we don't currently have a
reason to provide an id. Since this is a dictionary, developers can add
whatever fields they want but requiring an ID is unnecessary.