Disallow multiple showing payment requests per user agent #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Return a rejected promise, instead of throwing, in the first step * Use less verbose and confusing ways of manipulating internal slots * Be sure to return a promise when optionally aborting the algorithm * Make it clear we're aborting the in-parallel steps, later
We previously worked on this and thought we fixed it in #405, but we missed some in the accepts algorithm. Additionally, we should ideally not be *reading* internal slots of user-visible objects without first queuing a task.
marcoscaceres
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a few separate ground-laying commits while I was in the area, plus a third commit actually implementing the discussion from #462. Ideally they should be merged separately (with "rebase and merge").
Preview | Diff