Skip to content

Use "NotAllowedError" instead of "QuotaExceededError" #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2017
Merged

Use "NotAllowedError" instead of "QuotaExceededError" #488

merged 1 commit into from
Apr 5, 2017

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Mar 30, 2017 •
edited by pr-preview bot
Loading

Fixes #485.

@nickjshearer is this what you had in mind?

Preview | Diff

marcoscaceres
marcoscaceres approved these changes Mar 31, 2017
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note we've made this change on the Gecko side.

@zkoch zkoch merged commit 42916cb into gh-pages Apr 5, 2017
@marcoscaceres marcoscaceres deleted the notallowederror branch April 5, 2017 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees

No one assigned

Labels

cr-substantive

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@domenic @marcoscaceres @zkoch