Remove inline issues #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
reviewed
Aug 27, 2024
Comment on lines
2278
to
2311
| <p class="issue" title="(AT RISK) Hash values might change during Candidate Recommendation"> | ||
| This section lists cryptographic hash values that might change during the | ||
| Candidate Recommendation phase based on implementer feedback that requires | ||
| the referenced files to be modified. | ||
| </p> |
There was a problem hiding this comment.
We specifically do not want to remove this issue because it's something implementers need to be aware of. Replace this change with a data-number markup: https://respec.org/docs/#data-number
There was a problem hiding this comment.
Done. @msporny, please re-review.
msporny
approved these changes
Aug 27, 2024
selfissued
added
pr exists
decentralgabe
approved these changes
Aug 30, 2024
msporny
pushed a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #72 and #73 replace the inline issues removed.
Fixes #52.
Preview | Diff