Skip to content

Conversation

@msporny
Copy link
Member

@msporny msporny commented Sep 2, 2024

This PR is an attempt to address issue #65 by clarifying the cryptographic hash length and encoding.


Preview | Diff

Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. But before merging, please either define "varint" or add a reference to the specification defining it.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval bound to @selfissued's comment on varint.

@msporny msporny force-pushed the msporny-hash-length branch from 5b29fa2 to 29f350c Compare September 6, 2024 21:27
@msporny
Copy link
Member Author

msporny commented Sep 8, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit d49802d into main Sep 8, 2024
@msporny msporny deleted the msporny-hash-length branch September 8, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial This item is editorial in nature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants