-
Notifications
You must be signed in to change notification settings - Fork 11
Clarify representation of cryptographic hash length. #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. But before merging, please either define "varint" or add a reference to the specification defining it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval bound to @selfissued's comment on varint.
5b29fa2 to
29f350c
Compare
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
This PR is an attempt to address issue #65 by clarifying the cryptographic hash length and encoding.
Preview | Diff