Define "Multibase header" and reference it from datatype section. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
BigBlueHat,
TallTed,
brentzundel,
decentralgabe,
dlongley,
iherman,
jandrieu and
longpd
selfissued
approved these changes
Sep 2, 2024
dlongley
approved these changes
Sep 3, 2024
iherman
approved these changes
Sep 3, 2024
msporny
force-pushed
the
msporny-multibase-header
branch
from
278d4e8 to
1ec15de
Compare
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
TallTed
reviewed
Sep 10, 2024
Comment on lines
+2506
to
+2507
| the value based on the base-decoding alphabet associated with the first | ||
| [=Multibase header=] in the lexical string. |
There was a problem hiding this comment.
Can there be more than one Multibase header in such a lexical string? Or is first unnecessary here?
There was a problem hiding this comment.
It might be more accurate to using the first character of the lexical string as the multibase header. I think this text was intended to make it clear that while the lexical string is composed of many characters (of course), it is the first one (the first character) that expresses the multibase header.
There was a problem hiding this comment.
Suggested change
| the value based on the base-decoding alphabet associated with the first | |
| [=Multibase header=] in the lexical string. | |
| the value based on the base-decoding alphabet associated with the | |
| [=Multibase header=] (i.e., the first character) in the lexical string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #69 by defining the "multibase header" type and referencing it from the datatype section.
Preview | Diff