Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts-5] Various Edits #6154

Merged
merged 8 commits into from
Apr 6, 2021
Merged

[css-fonts-5] Various Edits #6154

merged 8 commits into from
Apr 6, 2021

Conversation

fantasai
Copy link
Collaborator

@fantasai fantasai commented Mar 27, 2021

Edits for the various metrics descriptors. Commit-by-commit review recommended. (It's not separate PRs because they build on each other. Please don't make me submit them one by one, I'll end up tangling all the branches in git...)

@fantasai
Copy link
Collaborator Author

reminder: DO NOT SQUASH WHEN MERGING

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, collides with #6137

@fantasai
Copy link
Collaborator Author

@svgeesus Indeed. I guess it's up to you which set of edits you like better. :)

css-fonts-5/Overview.bs Outdated Show resolved Hide resolved
@fantasai
Copy link
Collaborator Author

fantasai commented Apr 6, 2021

Ok, fixed the merge conflicts. Someone please decide whether or not this is acceptable?????

@svgeesus svgeesus merged commit bfef877 into w3c:main Apr 6, 2021
@fantasai fantasai deleted the css-fonts-5 branch April 6, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants