-
Notifications
You must be signed in to change notification settings - Fork 17
Remove resolveRepresentation() function #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove resolveRepresentation() function #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending minor fixes
Co-authored-by: Will Abramson <wip.abramson@gmail.com>
This was discussed during the #did meeting on 27 February 2025. View the transcriptw3c/did-resolution#123wip: hopefully we can get these updated and merged.... markus_sabadello: yes this is a consequence on the controlled identifier... markus_sabadello: this PR solves some issues on.. no longer necessary to distinguish between a resolve() and resolveRepresentation() function. markus_sabadello: from my pov this is looking good manu: yes +1 to that PR.... manu: yes let me take a look at it... manu: I undertstand this is a simplification that others have asked tallted: reminder to use SVG instead of PNG where possible... pchampin: yes perhaps sad to see the loss of the abstract data model... pchampin: one argument was that it was not testable... manu: this has caused so much conflict, that adding any note would just create conflict... manu: in regards to Teds.. point... I will leave these as PNGs this would be complex... manu: I think Ted's suggestion is so that we ease everyone's job... manu: perhaps this can be solved with just HTML and some CSS styling... <TallTed> +1 as manu says, changing these example images to HTML would be fine. markus_sabadello: Yes I agree... I think I can use either SVG or HTML... will do that... wip: ok thanks.... <manu> +1 to raising a separate issue to deal w/ the conversation. <Wip> w3c/did-resolution#114 wip: if you look at the issue that triggered this change... wip: is that you were referring to Pierre? manu: I think its different.... with CBOR LD .... manu: ... I don't think we should prevent implementations from having other representations of did documents... manu: this is not an abstract data model thing... manu: that is a decision up to the implementer... manu: we can still support accept headers... |
Merging after approval and no objections. |
Addresses #114
With changes in DID Core that added a dependency on CID (see w3c/did#877), it is no longer necessary to distinguish between a
resolve()
andresolveRepresentation()
function.Preview | Diff