Skip to content

Editorial revision to definitions of locn:geometry, dcat:bbox, dcat:centroid #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 11, 2021
Merged

Editorial revision to definitions of locn:geometry, dcat:bbox, dcat:centroid #1423

merged 7 commits into from
Nov 11, 2021

Conversation

@andrea-perego
Copy link
Contributor

See #1392 (comment)

This PR tries to address the ambiguity of the term "resource" in the definitions of properties locn:geometry, dcat:bbox, and dcat:centroid by replacing it with "spatial thing", in the SDW-BP sense - see https://www.w3.org/TR/sdw-bp/#spatial-things-features-and-geometry

@andrea-perego
Revise definition of spatial properties
1af710d 
Relevant issue: #1392

Replace "resource" with "spatial thing" (in the SDW-BP sense) in the definition of `locn:geometry`, `dcat:bbox`, and `dcat:centroid`.
@andrea-perego
Editorial fix
b21d981
@andrea-perego andrea-perego linked an issue Nov 9, 2021 that may be closed by this pull request
Semantics of the dcat:bbox attribute could (should?) be more explicit #1392
Closed
@andrea-perego andrea-perego added dcat Editorial feedback Issues stemming from external feedback to the WG locn:geometry labels Nov 9, 2021
@andrea-perego andrea-perego added this to the DCAT3 3PWD milestone Nov 9, 2021
@andrea-perego andrea-perego marked this pull request as ready for review November 9, 2021 22:38
@andrea-perego
Copy link
Contributor Author

Thanks for endorsing this proposal, @riccardoAlbertoni .

Once we agree on the revision to be made, we need to update the RDF vocabulary accordingly before merging this PR.

dr-shorthair
dr-shorthair reviewed Nov 10, 2021
View reviewed changes
davebrowning
davebrowning approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@davebrowning davebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the RDF needs to be updated to bring it into line, but the changes look like the right step.

@andrea-perego
Copy link
Contributor Author

Noting that the RDF needs to be updated to bring it into line, but the changes look like the right step.

Thanks, @davebrowning . I just revised the English definitions in dcat3.ttl and dcat-external.ttl. We need to generate the other serialisations before merging.

@riccardoAlbertoni
Copy link
Contributor

The other serializations have been generated.

@riccardoAlbertoni riccardoAlbertoni merged commit fd92b94 into gh-pages Nov 11, 2021
@riccardoAlbertoni riccardoAlbertoni deleted the dcat-fix-issue-1392 branch November 11, 2021 10:22
@andrea-perego andrea-perego mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dr-shorthair dr-shorthair dr-shorthair left review comments

@riccardoAlbertoni riccardoAlbertoni riccardoAlbertoni approved these changes

@davebrowning davebrowning davebrowning approved these changes

@agbeltran agbeltran Awaiting requested review from agbeltran

@pwin pwin Awaiting requested review from pwin

Assignees

No one assigned

Labels

dcat Editorial feedback Issues stemming from external feedback to the WG locn:geometry

Projects

None yet

Milestone

DCAT3 3PWD

Development

Successfully merging this pull request may close these issues.

Semantics of the dcat:bbox attribute could (should?) be more explicit

5 participants

@andrea-perego @riccardoAlbertoni @dr-shorthair @davebrowning