Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

image decoding #1101

Closed
Malvoz opened this issue Dec 7, 2017 · 5 comments
Closed

image decoding #1101

Malvoz opened this issue Dec 7, 2017 · 5 comments

Comments

@Malvoz
Copy link

Malvoz commented Dec 7, 2017

Using Nu html checker, I was alerted of:

Error: Attribute decoding not allowed on element img at this point.

And because it is not in the w3c spec yet, I thought I should flag for the img.decode() and <img decoding> attribute here.

@chaals
Copy link
Collaborator

chaals commented Dec 14, 2017

Is there a browser where the decode tests pass - and likewise for implementations of the attribute...

@chaals chaals added this to the When it's ready milestone Dec 14, 2017
@Malvoz
Copy link
Author

Malvoz commented Feb 16, 2018

@chaals
I'm sorry for not getting back to you sooner. I did manual decode testing which failed in
Edge 41.16299.15.0 and Firefox 58.0.2 but passed all tests in Chrome 64.0.3282.167:

Result Test Name Message
Pass HTMLImageElement.prototype.decode(), basic tests. Image with PNG src decodes with undefined.  
Pass HTMLImageElement.prototype.decode(), basic tests. Image with PNG data URL src decodes with undefined.  
Pass HTMLImageElement.prototype.decode(), basic tests. Image with SVG src decodes with undefined.  
Pass HTMLImageElement.prototype.decode(), basic tests. Non-existent src fails decode.  
Pass HTMLImageElement.prototype.decode(), basic tests. Inactive document fails decode.  
Pass HTMLImageElement.prototype.decode(), basic tests. Adopted active image into inactive document fails decode.  
Pass HTMLImageElement.prototype.decode(), basic tests. Adopted inactive image into active document succeeds.  
Pass HTMLImageElement.prototype.decode(), basic tests. Corrupt image in src fails decode.  
Pass HTMLImageElement.prototype.decode(), basic tests. Image without src/srcset fails decode.  
Pass HTMLImageElement.prototype.decode(), basic tests. Multiple decodes for images with src succeed.  
Pass HTMLImageElement.prototype.decode(), basic tests. Image with PNG srcset decodes with undefined.  
Pass HTMLImageElement.prototype.decode(), basic tests. Image with SVG srcset decodes with undefined.  
Pass HTMLImageElement.prototype.decode(), basic tests. Non-existent srcset fails decode.  
Pass HTMLImageElement.prototype.decode(), basic tests. Multiple decodes for images with srcset succeed.  

@chaals
Copy link
Collaborator

chaals commented Feb 16, 2018

Given apparent intent to implement this in Firefox now I am happy to get it into this version, marked 'at risk'.

@chaals
Copy link
Collaborator

chaals commented Feb 16, 2018

Hopefully we can get it in this or the next milestone, although without more movement on implementation in another browser I'm not going to rush for this...

cynthia added a commit to cynthia/html that referenced this issue Mar 11, 2018
This has a handful of both upstream tracking issues and patches,
which would be a bit much to list on a commit message. This will
be listed in w3c#1101.
@cynthia cynthia self-assigned this Mar 11, 2018
@cynthia
Copy link
Member

cynthia commented Mar 11, 2018

This has been lumped into a somewhat unrelated pull request - see #1287.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants