Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

add definition of EventHandler to 5.1 errata #930

Merged
merged 1 commit into from
May 30, 2017
Merged

add definition of EventHandler to 5.1 errata #930

merged 1 commit into from
May 30, 2017

Conversation

siusin
Copy link
Contributor

@siusin siusin commented May 25, 2017

Preview: http://rawgit.com/siusin/html/html5.1-2-add-eventhandler/single-page.html

  1. Added definition of EventHandler, OnErrorEventHandler, OnErrorEventHandler, OnBeforeUnloadEventHandlerNonNull, and OnBeforeUnloadEventhandler (editorial) -- to fix HTML 5.1 is missing the definition of EventHandler #927 .
  2. Update the other HTML 4 system identifiers reverted by 62e0776 -- to fix Add module scripts #469 . cc @tstarling
  3. revert the change of abstract. It seems those words will make better sense in the Status of the Document. Thoughts?
  4. Use Process 2017 for this new publication?

@@ -8600,7 +8600,7 @@ <h4 class="heading settled" data-level="3.1.1" id="the-document-object"><span cl
<span class="kt">DOMString</span> <dfn class="nv idl-code" data-dfn-for="Document" data-dfn-type="method" data-export="" data-lt="queryCommandValue(commandId)" id="dom-document-querycommandvalue">queryCommandValue<a class="self-link" href="#dom-document-querycommandvalue"></a></dfn>(<span class="kt">DOMString</span> <dfn class="nv idl-code" data-dfn-for="Document/queryCommandValue(commandId)" data-dfn-type="argument" data-export="" id="dom-document-querycommandvalue-commandid-commandid">commandId<a class="self-link" href="#dom-document-querycommandvalue-commandid-commandid"></a></dfn>);

// special event handler IDL attributes that only apply to Document objects
[<a class="nv idl-code" data-link-type="extended-attribute" href="https://heycam.github.io/webidl/#LenientThis">LenientThis</a>] <span class="kt">attribute</span> <a class="n" data-link-type="idl-name" href="https://html.spec.whatwg.org/multipage/webappapis.html#eventhandler">EventHandler</a> <dfn class="nv idl-code" data-dfn-for="Document" data-dfn-type="attribute" data-export="" data-type="EventHandler" id="dom-document-onreadystatechange">onreadystatechange<a class="self-link" href="#dom-document-onreadystatechange"></a></dfn>;
[<a class="nv idl-code" data-link-type="extended-attribute" href="https://heycam.github.io/webidl/#LenientThis">LenientThis</a>] <span class="kt">attribute</span> <a class="n" data-link-type="idl-name" href="#typedefdef-eventhandler" id="ref-for-typedefdef-eventhandler-1">EventHandler</a> <dfn class="nv idl-code" data-dfn-for="Document" data-dfn-type="attribute" data-export="" data-type="EventHandler" id="dom-document-onreadystatechange">onreadystatechange<a class="self-link" href="#dom-document-onreadystatechange"></a></dfn>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't the link here be https://www.w3.org/TR/WebIDL-1/#LenientThis ?

Copy link
Collaborator

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about linking to the WebIDL repo version instead of the W3C Rec. Otherwise, LGTM but I didn't check that you have every link correct.

@@ -1467,7 +1464,10 @@ <h2 class="no-num no-toc no-ref heading settled" id="status"><span class="conten
technical report can be found in the <a href="https://www.w3.org/TR/"><abbr title="World Wide Web Consortium">W3C</abbr> technical
reports index</a> at https://www.w3.org/TR/.</em> </p>

<p><a href="https://github.com/w3c/html/labels/errata">Errata</a> for this document are recorded as Github issues with the "errata" label.The <a href="https://w3c.github.io/html/">latest HTML editors' draft</a> shows proposed resolutions of errata <i>in situ</i>.</p>

<p>This specification defines the 2nd edition of the 5th major version, first minor revision of the core language of the World Wide Web: the Hypertext Markup Language (HTML). In this version, a significant error with <a href="https://w3.org/tr/51/">HTML 5.1</a> has been rectified, as noted in the <a href="errata">Errata corrected</a> section.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<a href="errata">Errata corrected</a>

should that be href="#errata" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually I dont think we have a "#errata" page... Should we use <a href="https://github.com/w3c/html/labels/errata">Errata corrected</a>?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever comes out of #931 - but that need not hold up CR. It's necessary for the Edited Rec.


<p>This specification defines the 2nd edition of the 5th major version, first minor revision of the core language of the World Wide Web: the Hypertext Markup Language (HTML). In this version, a significant error with <a href="https://w3.org/tr/51/">HTML 5.1</a> has been rectified, as noted in the <a href="errata">Errata corrected</a> section.</p>

<p><a href="https://github.com/w3c/html/labels/errata">Errata</a> for this document are recorded as Github issues with the "errata" label. The <a href="https://w3c.github.io/html/">latest HTML editors' draft</a> shows proposed resolutions of errata <i>in situ</i>.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we track errata by project, so we would set up a project for any spec that has an erratum, as well as the label?

I hope we don't have a lot of errata, but I can imagine 1 or 2 per year meaning we have a page-long list, and will want to make it clear that most of them aren't what someone is looking for - assuming that is mostly errata for the then-current version…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem weird to mix issues for the current editor's draft (or future draft) for which we intend to drive to zero, with errata issues that persist indefinitely for past branches of the spec. I think it might be better to just maintain a separate *.md document (separately) for errata--so that it doesn't show up in the issues list.

Copy link
Collaborator

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, some more comments.

@LJWatson
Copy link
Collaborator

Thanks @chaals and @siusin. I don't have time for a proper review, but since I did the earlier work on this document, Chaals' review LGTM.

@LJWatson
Copy link
Collaborator

@chaals I've opened a separate issue on errata tracking (#931), and have pinged p-html for comments and ideas.

@travisleithead
Copy link
Member

Given that #931 is filed, I have no other feedback on this PR. +LGTM.

@travisleithead travisleithead merged commit 058c7bb into w3c:html5.1-2 May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants