-
Notifications
You must be signed in to change notification settings - Fork 544
add definition of EventHandler to 5.1 errata #930
add definition of EventHandler to 5.1 errata #930
Conversation
@@ -8600,7 +8600,7 @@ <h4 class="heading settled" data-level="3.1.1" id="the-document-object"><span cl | |||
<span class="kt">DOMString</span> <dfn class="nv idl-code" data-dfn-for="Document" data-dfn-type="method" data-export="" data-lt="queryCommandValue(commandId)" id="dom-document-querycommandvalue">queryCommandValue<a class="self-link" href="#dom-document-querycommandvalue"></a></dfn>(<span class="kt">DOMString</span> <dfn class="nv idl-code" data-dfn-for="Document/queryCommandValue(commandId)" data-dfn-type="argument" data-export="" id="dom-document-querycommandvalue-commandid-commandid">commandId<a class="self-link" href="#dom-document-querycommandvalue-commandid-commandid"></a></dfn>); | |||
|
|||
// special event handler IDL attributes that only apply to Document objects | |||
[<a class="nv idl-code" data-link-type="extended-attribute" href="https://heycam.github.io/webidl/#LenientThis">LenientThis</a>] <span class="kt">attribute</span> <a class="n" data-link-type="idl-name" href="https://html.spec.whatwg.org/multipage/webappapis.html#eventhandler">EventHandler</a> <dfn class="nv idl-code" data-dfn-for="Document" data-dfn-type="attribute" data-export="" data-type="EventHandler" id="dom-document-onreadystatechange">onreadystatechange<a class="self-link" href="#dom-document-onreadystatechange"></a></dfn>; | |||
[<a class="nv idl-code" data-link-type="extended-attribute" href="https://heycam.github.io/webidl/#LenientThis">LenientThis</a>] <span class="kt">attribute</span> <a class="n" data-link-type="idl-name" href="#typedefdef-eventhandler" id="ref-for-typedefdef-eventhandler-1">EventHandler</a> <dfn class="nv idl-code" data-dfn-for="Document" data-dfn-type="attribute" data-export="" data-type="EventHandler" id="dom-document-onreadystatechange">onreadystatechange<a class="self-link" href="#dom-document-onreadystatechange"></a></dfn>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't the link here be https://www.w3.org/TR/WebIDL-1/#LenientThis ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about linking to the WebIDL repo version instead of the W3C Rec. Otherwise, LGTM but I didn't check that you have every link correct.
@@ -1467,7 +1464,10 @@ <h2 class="no-num no-toc no-ref heading settled" id="status"><span class="conten | |||
technical report can be found in the <a href="https://www.w3.org/TR/"><abbr title="World Wide Web Consortium">W3C</abbr> technical | |||
reports index</a> at https://www.w3.org/TR/.</em> </p> | |||
|
|||
<p><a href="https://github.com/w3c/html/labels/errata">Errata</a> for this document are recorded as Github issues with the "errata" label.The <a href="https://w3c.github.io/html/">latest HTML editors' draft</a> shows proposed resolutions of errata <i>in situ</i>.</p> | |||
|
|||
<p>This specification defines the 2nd edition of the 5th major version, first minor revision of the core language of the World Wide Web: the Hypertext Markup Language (HTML). In this version, a significant error with <a href="https://w3.org/tr/51/">HTML 5.1</a> has been rectified, as noted in the <a href="errata">Errata corrected</a> section.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="errata">Errata corrected</a>
should that be href="#errata" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually I dont think we have a "#errata" page... Should we use <a href="https://github.com/w3c/html/labels/errata">Errata corrected</a>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever comes out of #931 - but that need not hold up CR. It's necessary for the Edited Rec.
|
||
<p>This specification defines the 2nd edition of the 5th major version, first minor revision of the core language of the World Wide Web: the Hypertext Markup Language (HTML). In this version, a significant error with <a href="https://w3.org/tr/51/">HTML 5.1</a> has been rectified, as noted in the <a href="errata">Errata corrected</a> section.</p> | ||
|
||
<p><a href="https://github.com/w3c/html/labels/errata">Errata</a> for this document are recorded as Github issues with the "errata" label. The <a href="https://w3c.github.io/html/">latest HTML editors' draft</a> shows proposed resolutions of errata <i>in situ</i>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we track errata by project, so we would set up a project for any spec that has an erratum, as well as the label?
I hope we don't have a lot of errata, but I can imagine 1 or 2 per year meaning we have a page-long list, and will want to make it clear that most of them aren't what someone is looking for - assuming that is mostly errata for the then-current version…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem weird to mix issues for the current editor's draft (or future draft) for which we intend to drive to zero, with errata issues that persist indefinitely for past branches of the spec. I think it might be better to just maintain a separate *.md document (separately) for errata--so that it doesn't show up in the issues list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, some more comments.
Given that #931 is filed, I have no other feedback on this PR. +LGTM. |
Preview: http://rawgit.com/siusin/html/html5.1-2-add-eventhandler/single-page.html