Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made (current) editors as 2nd edition #103

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Jul 8, 2019

for #89
not sure this format is ok or not....


Preview | Diff

@himorin himorin requested a review from r12a July 8, 2019 07:11
@r12a
Copy link
Contributor

r12a commented Jul 8, 2019

I think there are too many parentheses. Eg. i would, if it were me, change

{   name:       "<span lang='ja'>小林 龍生</span> (Tatsuo Kobayashi)",
    company:    "Invited Expert (2nd edition); JustSystems (1st edition)" },

to

{   name:       "<span lang='ja'>小林 龍生</span> (Tatsuo Kobayashi)",
    company:    "1st edition, JustSystems; 2nd edition, Invited Expert" },

Also you need to add Nat, Fuqiao, and yourself to the list.

@xfq
Copy link
Member

xfq commented Jul 9, 2019

I wonder why we only have lang, but no its-locale-filter-list in the spans. Is it intentional?

@r12a
Copy link
Contributor

r12a commented Jul 9, 2019

yes. We always show both forms of a person's name together on all our documents.

@xfq
Copy link
Member

xfq commented Jul 9, 2019

Also for "第1版 1st edition"?

@r12a
Copy link
Contributor

r12a commented Jul 9, 2019

ah, that might be different. (I think there were some issues with language switching on this front matter, but i don't remember the detail off the top of my head, and they may not apply here.)

@himorin
Copy link
Contributor Author

himorin commented Jul 9, 2019

I think there are too many parentheses. Eg. i would, if it were me, change

Thank you for pointing! Modified as suggested.

Also you need to add Nat, Fuqiao, and yourself to the list.

for me, it seems better to add another issue/PR (and check/approval?) from chairs (or the wind?).
let me add another issue shortly.

@himorin
Copy link
Contributor Author

himorin commented Jul 26, 2019

@kidayasuo @r12a ok to merge this?

@himorin himorin merged commit 3266847 into w3c:gh-pages Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants