-
Notifications
You must be signed in to change notification settings - Fork 35
Order JsonLdErrorCode descriptions. #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sort the descriptions to match the ordered enum list above.
Also sorted RemoteDocument descriptions to match IDL above. |
Hmm. Maybe this isn't needed and the RemoteDocument dl is just missing data-sort attribute? If that's the case, the proper patch is probably to add the data-sort attribute and manually resort the JsonLdErrorCode list to match the sorting data-sort does. (just piping through "sort" puts the IRI thing at top and orders some things slightly different) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use data-sort
.
For IDL sections, I assume it's desired to have the IDL item list match the description list. If descriptions are using |
Method parameters should stay in order, and of course, algorithm steps. Otherwise, I think we can use It's not too important that the HTML source be ordered if we're using |
This issue was discussed in a meeting.
View the transcript[api] Order JsonLdErrorCode descriptionsBenjamin Young: #409 Gregg Kellogg: other is reordering error code. Normally we use <dl> with data-sort attribute that orders them, but this maybe doesn’t use data-sort … so need to get the text in the HTML to align with the sort order David I. Lehn: ordering thing is not very exciting :) … if we use data-sort it will put it in a particular order. And the IDL should be the same order as the -sort … everything should be ordered the same. Wasn’t sure what to do, and ran out of time on it Gregg Kellogg: up to the editors for what to do. Doesn’t affect the rendered document at all. Do things exist in the source where you expect them … so a good idea to have in the same order. data-sort corrects for past errors … if someone wants to do it, that’s great David I. Lehn: I sorted the values by piping through sort locally … which put IRI at the top Gregg Kellogg: Good to just do what the algorithm does David I. Lehn: Will just make it look right :) Gregg Kellogg: don’t sort method param lists … as they’re in the order they’re used in the method definition … but error codes, enum values don’t order by default … and need to be done manually, but keeping the enum in the order below makes the most sense … IRI comes first due to caps … whereas in data-sort it’s after invalid David I. Lehn: Which things to not sort? Gregg Kellogg: in jsonld processor interface, the definitions of the methods, there’s definitions of the three params … those should not be ordered alphabeitcally but in the order they appear in the method definition David I. Lehn: Right, okay. I’ll work on an update Gregg Kellogg: Great, need to sign off … will push syntax today Benjamin Young: Great, thanks, bye! … revisit 415? Rob Sanderson: [crickets] |
… be consistent with data-sort.
Sort the descriptions to match the ordered enum list above.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Mar 15, 2020, 7:58 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.