Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TAO checks with same origin check #108

Merged
merged 5 commits into from Jun 19, 2019

Conversation

@yoavweiss
Copy link
Contributor

commented Jun 12, 2019

Fixes #104


Preview | Diff

@yoavweiss yoavweiss requested review from igrigorik and npm1 Jun 12, 2019

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Added same origin check
review comments

@yoavweiss yoavweiss force-pushed the yoavweiss:same_origin_check branch from 7177ed6 to db2ccbf Jun 19, 2019

@npm1

npm1 approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

lgtm % comments

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved

yoavweiss added some commits Jun 19, 2019

@yoavweiss yoavweiss merged commit 9453716 into w3c:gh-pages Jun 19, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
ipr PR deemed acceptable.
Details

@yoavweiss yoavweiss deleted the yoavweiss:same_origin_check branch Jun 19, 2019

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jun 20, 2019

[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108
@yoavweiss

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Related tests are PRed as part of a Chromium CL

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jun 20, 2019

[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jun 20, 2019

[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jun 20, 2019

[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743

aarongable pushed a commit to chromium/chromium that referenced this pull request Jun 21, 2019

Yoav Weiss Commit Bot
[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jun 21, 2019

[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jun 21, 2019

[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

marcoscaceres added a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019

[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 24, 2019

Bug 1560908 [wpt PR 17412] - [Navigation Timing] Replace TAO restrict…
…ions with same-origin ones, a=testonly

Automatic update from web-platform-tests
[Navigation Timing] Replace TAO restrictions with same-origin ones

The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

--

wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a
wpt-pr: 17412

xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jul 25, 2019

Bug 1560908 [wpt PR 17412] - [Navigation Timing] Replace TAO restrict…
…ions with same-origin ones, a=testonly

Automatic update from web-platform-tests
[Navigation Timing] Replace TAO restrictions with same-origin ones

The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

--

wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a
wpt-pr: 17412

gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jul 25, 2019

Bug 1560908 [wpt PR 17412] - [Navigation Timing] Replace TAO restrict…
…ions with same-origin ones, a=testonly

Automatic update from web-platform-tests
[Navigation Timing] Replace TAO restrictions with same-origin ones

The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

--

wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a
wpt-pr: 17412

UltraBlame original commit: 32a886c5c867b4727adf314786c9c07adc7729a7

gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jul 31, 2019

Bug 1560908 [wpt PR 17412] - [Navigation Timing] Replace TAO restrict…
…ions with same-origin ones, a=testonly

Automatic update from web-platform-tests
[Navigation Timing] Replace TAO restrictions with same-origin ones

The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

--

wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a
wpt-pr: 17412

UltraBlame original commit: 32a886c5c867b4727adf314786c9c07adc7729a7

gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jul 31, 2019

Bug 1560908 [wpt PR 17412] - [Navigation Timing] Replace TAO restrict…
…ions with same-origin ones, a=testonly

Automatic update from web-platform-tests
[Navigation Timing] Replace TAO restrictions with same-origin ones

The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.

Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.

This CL aligns the implementation with the new language.

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147

[1] w3c/navigation-timing#108

Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}

--

wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a
wpt-pr: 17412

UltraBlame original commit: 32a886c5c867b4727adf314786c9c07adc7729a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.