Replace TAO checks with same origin check #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm1
requested changes
Jun 13, 2019
review comments
yoavweiss
force-pushed
the
same_origin_check
branch
from
7177ed6
to
db2ccbf
Compare
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108
|
Related tests are PRed as part of a Chromium CL |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 21, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671229}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 21, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671229}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 21, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671229}
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671229}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2019
…ions with same-origin ones, a=testonly Automatic update from web-platform-tests [Navigation Timing] Replace TAO restrictions with same-origin ones The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671229} -- wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a wpt-pr: 17412
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2019
…ions with same-origin ones, a=testonly Automatic update from web-platform-tests [Navigation Timing] Replace TAO restrictions with same-origin ones The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671229} -- wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a wpt-pr: 17412
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…ions with same-origin ones, a=testonly Automatic update from web-platform-tests [Navigation Timing] Replace TAO restrictions with same-origin ones The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweisschromium.org> Reviewed-by: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#671229} -- wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a wpt-pr: 17412 UltraBlame original commit: 32a886c5c867b4727adf314786c9c07adc7729a7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…ions with same-origin ones, a=testonly Automatic update from web-platform-tests [Navigation Timing] Replace TAO restrictions with same-origin ones The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweisschromium.org> Reviewed-by: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#671229} -- wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a wpt-pr: 17412 UltraBlame original commit: 32a886c5c867b4727adf314786c9c07adc7729a7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ions with same-origin ones, a=testonly Automatic update from web-platform-tests [Navigation Timing] Replace TAO restrictions with same-origin ones The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweisschromium.org> Reviewed-by: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#671229} -- wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a wpt-pr: 17412 UltraBlame original commit: 32a886c5c867b4727adf314786c9c07adc7729a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
Preview | Diff