-
Notifications
You must be signed in to change notification settings - Fork 38
Rename SpeechRecognitionError to SpeechRecognitionErrorEvent #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c0f4a8 to
6fe4c4e
Compare
saschanaz
approved these changes
Jul 6, 2018
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 6, 2018
Collaborator
Author
|
I added a negative test in web-platform-tests/wpt#12320. web-platform-tests/wpt#12317 adds idlharness.js tests for Web Speech API, and when the IDL change is made in the spec it will eventaully propagate to wpt interfaces/ to cover this. (Testing the constructor is a separate matter which will be done when the constructors are added.) |
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 6, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 8, 2018
…rror, a=testonly Automatic update from web-platform-testsAdd negative test for SpeechRecognitionError (#12320) Follows WebAudio/web-speech-api#23. -- wpt-commits: 6ab60d65618bb37f0d473624a4c3289edbada3ae wpt-pr: 12320
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Aug 8, 2018
…rror, a=testonly Automatic update from web-platform-testsAdd negative test for SpeechRecognitionError (#12320) Follows WebAudio/web-speech-api#23. -- wpt-commits: 6ab60d65618bb37f0d473624a4c3289edbada3ae wpt-pr: 12320
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…rror, a=testonly Automatic update from web-platform-testsAdd negative test for SpeechRecognitionError (#12320) Follows WebAudio/web-speech-api#23. -- wpt-commits: 6ab60d65618bb37f0d473624a4c3289edbada3ae wpt-pr: 12320 UltraBlame original commit: 4c38630b6bc7614080d3c1181b8d41aa6d488da3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…rror, a=testonly Automatic update from web-platform-testsAdd negative test for SpeechRecognitionError (#12320) Follows WebAudio/web-speech-api#23. -- wpt-commits: 6ab60d65618bb37f0d473624a4c3289edbada3ae wpt-pr: 12320 UltraBlame original commit: 4c38630b6bc7614080d3c1181b8d41aa6d488da3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…rror, a=testonly Automatic update from web-platform-testsAdd negative test for SpeechRecognitionError (#12320) Follows WebAudio/web-speech-api#23. -- wpt-commits: 6ab60d65618bb37f0d473624a4c3289edbada3ae wpt-pr: 12320 UltraBlame original commit: 4c38630b6bc7614080d3c1181b8d41aa6d488da3
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 27, 2020
WebAudio/web-speech-api#23 renamed SpeechRecognitionError to SpeechRecognitionErrorEvent. (No engines other than Blink/Chromium yet implement it as SpeechRecognitionErrorEvent, and no others ever implemented SpeechRecognitionError.) chromium/chromium@5dbd1fc
queengooborg
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Feb 13, 2020
* Add SpeechRecognitionErrorEvent WebAudio/web-speech-api#23 renamed SpeechRecognitionError to SpeechRecognitionErrorEvent. (No engines other than Blink/Chromium yet implement it as SpeechRecognitionErrorEvent, and no others ever implemented SpeechRecognitionError.) chromium/chromium@5dbd1fc * Delete SpeechRecognitionError This drops SpeechRecognitionError and updates SpeechRecognitionErrorEvent with an "alternative_name": "webkitSpeechRecognitionError" field (and appropriate version_added and version_removed values) for the Chrome-based UAs that shipped with it implemented under that older name. * SpeechRecognitionErrorEvent, update Edge version * SpeechRecognitionErrorEvent, tweak JSON formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: web-platform-tests/wpt#12320
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=21272.
Preview | Diff