Add SpeechSynthesisEvent charLength attribute #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
commented
Aug 6, 2018
| <dt><dfn attribute for=SpeechSynthesisEvent>charLength</dfn> attribute</dt> | ||
| <dd>This attribute indicates the length of the text (word or sentence) that will be spoken corresponding to this event. | ||
| This attribute is the length, in characters, starting from this event's {{charIndex}}. | ||
| The user agent must return this value if the speech synthesis engine supports it or the user agent can otherwise determine it, otherwise the user agent must return undefined.</dd> |
There was a problem hiding this comment.
It's actually not possible to "return undefined" since the type is unsigned long. This needs to be fixed here, above and below before merging this PR.
There was a problem hiding this comment.
Undefined seems to make sense. Any object that does not have the attribute that a user asks for will return undefined by default.
|
I'm just going to leave this PR sitting here until an implementer expresses interest. Then, what's additionally needed to merge it is tests in web-platform-tests. |
|
Superseded by #50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=30004.
Preview | Diff