Skip to content

Conversation

@foolip
Copy link
Collaborator

@foolip foolip commented Aug 6, 2018

Nothing can be done with these objects, as SpeechGrammarList is
populated using addFromURI/addFromString.

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26992.


Preview | Diff

Nothing can be done with these objects, as SpeechGrammarList is
populated using addFromURI/addFromString.

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26992.
@foolip
Copy link
Collaborator Author

foolip commented Aug 6, 2018

@smaug---- this is a fix for your reported issue, but https://github.com/mozilla/gecko-dev/blob/86897859913403b68829dbf9a154f5a87c4b0638/dom/webidl/SpeechGrammar.webidl#L13 does have the constructor. Is this change still desirable? cc @andrenatal

@saschanaz
Copy link
Contributor

I think the same applies for SpeechGrammarList.

@foolip
Copy link
Collaborator Author

foolip commented Aug 6, 2018

I haven't tried it, but just looking at the API shape, it looks like it's possible to create a new SpeechGrammarList, populate it with something, and then assign to grammars on a SpeechRecognition instance.

@saschanaz
Copy link
Contributor

Ah, you're right. It's not readonly and the setter works.

@smaug----
Copy link

Also blink has Constructor, though oddly it has also NoInterfaceObject.
But as far as I see, the change should be still done.
(all this discussion should happen in some issue, not in pr)

@marcoscaceres
Copy link
Collaborator

Filed #58 to drop grammars entirely. The format for the grammars is not specified at all in the spec, so these objects seem to serve no purpose at the moment?

@foolip foolip merged commit 75dfed2 into master Aug 5, 2019
@foolip foolip deleted the no-SpeechGrammar-constructor branch August 5, 2019 07:27
@evanbliu
Copy link
Collaborator

evanbliu commented Jan 7, 2025

The removal of SpeechGrammar from the Web Speech API spec was discussed at TPAC 2024 and the popular opinion was to remove it from the spec as it is under specified and unsupported by many implementations of the Web Speech API including Chrome.

thalinda-oss

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants