Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can pushMessage avoid pushing a sequence? #69

Closed
kenchris opened this issue Oct 15, 2015 · 1 comment · Fixed by #88
Closed

can pushMessage avoid pushing a sequence? #69

kenchris opened this issue Oct 15, 2015 · 1 comment · Fixed by #88
Labels
tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.

Comments

@kenchris
Copy link
Contributor

https://github.com/w3ctag/spec-reviews/blob/master/2015/10/nfc-feedback.md

pushMessage is highly structured (sequence). Why is it pushing a list? Shouldn't it push just one thing at a time? Is the grouping significant to the protocol? Can this be abstracted away?
@zolkis
Copy link
Contributor

zolkis commented Oct 15, 2015

This is coming from the structure of NDEF messages.

It cannot push one record at a time.

We could define an NDEFMessage structure for containing just the sequence, and then WebNFCMessage to be what NFCMessage is now.

zolkis added a commit to zolkis/web-nfc that referenced this issue Nov 4, 2015
@zolkis
Fix w3c#69, w3c#70, w3c#73, w3c#77, w3c#80, w3c#81, w3c#82, w3c#83, w…
12b905d 
…3c#84. Handle push related TAG review comments: simplified and aligned push message, optional push options with sensible defaults, improved push and cancelPush steps, option for suspending watches during push(), editorials.
@zolkis zolkis mentioned this issue Nov 4, 2015
Merged
@zolkis zolkis closed this as completed in #88 Nov 6, 2015
@plehegar plehegar added the tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response. label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TAG review comments. zolkis/web-nfc
3 participants
@zolkis @kenchris @plehegar