-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clamp NFCPushOptions.timeout and provide default values #81
Comments
Why not just write a note that the UA might clamp to a UA specific upper bound? |
Its ok to be explicit in the idl, geolocaltion, vibration, etc do it. |
@zolkis I wonder why other specs (MSE, WebAudio, Battery, DeviceLight) use "unrestricted double" for Infinity values? Should we also use: dictionary NFCPushOptions {
NFCPushTarget target = "any";
unrestricted double timeout; // default value +Infinity
}; |
Could we use |
@anssiko your input please? :) |
timeout: 0; means 0 ms, timer will be created and push operation would be cancelled in 0 ms. I have to represent "infinity" value somehow in implementation, at the moment I use "unrestricted double timeout;" in the idl, which is mapped to "double". std::numeric_limits<double>::has_infinity => true
std::numeric_limits<unsigned long long>::has_infinity => false
std::numeric_limits<unsigned long>::has_infinity => false |
OK, that solves it. Thanks. |
…3c#84. Handle push related TAG review comments: simplified and aligned push message, optional push options with sensible defaults, improved push and cancelPush steps, option for suspending watches during push(), editorials.
Change type of timeout to unrestricted double fix #81
If NFCPushOptions.timeout can be set to Infinity, it should be clamped.
It will be also nice to have default values set for:
NFCPushOptions.timeout to "0xFFFFFFFF max timeout"
NFCPushOptions.target to "tag" enumeration value
The text was updated successfully, but these errors were encountered: