Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the same NFCMessage both for push and read #80

Closed
zolkis opened this issue Oct 30, 2015 · 1 comment
Closed

Define the same NFCMessage both for push and read #80

zolkis opened this issue Oct 30, 2015 · 1 comment

Comments

@zolkis
Copy link
Contributor

zolkis commented Oct 30, 2015

  1. Currently pushMessage() takes as argument a sequence of records, whereas when NFC content is read, it is presented as an NFCMessage with a url and a sequence of records.
  2. Currently developers cannot control what path is written in the Web NFC Id. The steps currently say that URL path of the browsing context is written as Web NFC Id.

It would be good if we'd have the same NFCMessage definition both for push and reads.
Also, it would be nice if developers could control the path part of the Web NFC Id, but could not fake the scheme/host/port.

These two things could be solved together by modifying the pushMessage signature to:

Promise<void> push(NFCMessage message, NFCPushOptions options);

where message.url is supposed to provide a developer defined path.
If we don't want to support this, we could also say message.url is not currently used.

zolkis added a commit to zolkis/web-nfc that referenced this issue Nov 4, 2015
…3c#84. Handle push related TAG review comments: simplified and aligned push message, optional push options with sensible defaults, improved push and cancelPush steps, option for suspending watches during push(), editorials.
@zolkis
Copy link
Contributor Author

zolkis commented Nov 6, 2015

Fixed by #88.

@zolkis zolkis closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant