-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NFCPushOptions optional for pushMessage #82
Comments
If we can have sensible defaults, why not. Timeout could be set to Infinity as a default. |
We could also separate push (to peers) from write (to tags).
|
zolkis
added a commit
to zolkis/web-nfc
that referenced
this issue
Nov 4, 2015
…3c#84. Handle push related TAG review comments: simplified and aligned push message, optional push options with sensible defaults, improved push and cancelPush steps, option for suspending watches during push(), editorials.
Merged
Fixed by #88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my opinion, by making NFCPushOptions optional, we can improve API usability and developers would need to type less code for main use-cases.
The text was updated successfully, but these errors were encountered: