-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test that :read-only matches <input>s to which [readonly] doesn't apply #2843
Conversation
…ly and thus aren't :read-write
Critic review: https://critic.hoppipolla.co.uk/r/6400 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Reviewers for this pull request are: @Ms2ger, @foolip, @gsnedders, @jdm, @jgraham, @plehegar, @sideshowbarker, @zcorpan, and @zqzhang. |
Thanks for this! The tests match the spec AFAICT, but it's not clear to me that implementors want to match the spec. It's also pretty useless to have a selector for |
Yes, I agree that the spec isn't particularly reasonable here, but didn't dig in to evaluate whether the weirdness is justified or not (perhaps there's a history here).
Given their response to https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7229941/ , the Edge folks currently seem to be in the "the spec is bad" camp. |
This changed in WebKit in WebKit/WebKit@c097867 @BenjaminPoulain what are your thoughts? Also see @FremyCompany's comment in the Edge issue Maybe we should take this to www-style? |
That's pretty common. Take ":link" and ":visited" for example. I would expect :read-only and :read-write to be opposite, as it is for any permission system. That what follows the principle of least astonishment IMHO.
Yep. I do not intend to change WebKit to go against the spec. |
:link and :visited are mutually exclusive but are not the negation of each other; neither of them mathes a With contenteditable I suppose it's possible to argue that any element can become writeable, though. |
I'll merge this since it's correct per the current spec. I can start a new thread in www-style. |
The new thread: https://lists.w3.org/Archives/Public/www-style/2016Apr/0294.html |
…ly and thus aren't :read-write (web-platform-tests#2843)
This tests the other side of #2839.
As a reminder, per https://html.spec.whatwg.org/multipage/scripting.html#selector-read-only
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=604154
Refs https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7229941/