-
Notifications
You must be signed in to change notification settings - Fork 208
Remove the configurability of the user prompt behaviour #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not implemented in two separate implementations of webdriver. Punting to level 2, but specifying unconfigurable default behaviour for handling user prompts.
This is based on feedback from @AutomatedTester that this behaviour (dimiss and error) will work, and from @jimevans that this behaviour is implemented in the IEDriverServer. This brings us into line with Selenium's existing behaviour. |
andreastt
approved these changes
Nov 10, 2017
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 14, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY --HG-- extra : rebase_source : a990f0fa5643dc7e844e79b9f344126a49e79665
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Nov 14, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 15, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY --HG-- extra : rebase_source : dab2d8b96f3dc1dddb7b22127faf30e9e744b0bc
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Nov 15, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Nov 15, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Nov 15, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 18, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY --HG-- extra : rebase_source : d403cdd98d6ceaf2fc101e9371e4092ceb7558de
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Nov 18, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Nov 21, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY --HG-- extra : rebase_source : c8d75074273071fe4d701e69f6044d1ff94eb2f0
weilonge
pushed a commit
to weilonge/gecko
that referenced
this pull request
Nov 23, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Nov 28, 2017
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
jgraham
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 28, 2017
The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1416284 [ci skip]
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: 1902e83f331d87b7ac9dab8e324f9e689d9ef643
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: b1474e3a2e948a0a1394cdef584524b63cfa5ea1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: ff138177269bbe4c2a7c8c635a99a4912565dc64
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: 35dc4a31d7559d9d504032ced72bc34a1c1fb963
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: 1902e83f331d87b7ac9dab8e324f9e689d9ef643
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: b1474e3a2e948a0a1394cdef584524b63cfa5ea1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: 1902e83f331d87b7ac9dab8e324f9e689d9ef643
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: b1474e3a2e948a0a1394cdef584524b63cfa5ea1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: ff138177269bbe4c2a7c8c635a99a4912565dc64
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: 35dc4a31d7559d9d504032ced72bc34a1c1fb963
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: ff138177269bbe4c2a7c8c635a99a4912565dc64
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY UltraBlame original commit: 35dc4a31d7559d9d504032ced72bc34a1c1fb963
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
… r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See w3c/webdriver#1145 MozReview-Commit-ID: 1OnT1AMM0tY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not implemented in two separate implementations of
webdriver. Punting to level 2, but specifying unconfigurable
default behaviour for handling user prompts.
This change is