Add wheel source type to WebDriver Actions API Spec #1522

LanWei22 · 2020-06-02T10:58:57Z

The current Webdriver Actions API’s pointer source types have three input types: "mouse", "pen", and "touch". For the three pointer type, it only supports actions of "pointerDown", "pointerUp", "pointerMove" and "pointerCancel". We cannot generate a mouse wheel scroll from the current source types and actions. We want to add a new source type to generate wheel events to support testing wheel scroll or zoom on web pages.

The design doc is
https://docs.google.com/document/d/1AzPkvexzuUJ1SF-6pZFpnn2lwEYlk3T0e-Wi52UWFZ4/

WPT tests:
https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/uievents/order-of-events/mouse-events/wheel-scrolling-manual.htm
https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/uievents/order-of-events/mouse-events/wheel-basic-manual.html

Preview | Diff

AutomatedTester · 2020-06-02T11:23:24Z

Unfortunately this has a really poor commit message as it does not describe the work being done. Please correct this.

…

On Jun 2, 2020, 11:59 AM +0100, Lan Wei ***@***.***>, wrote: You can view, comment on, or merge this pull request online at: #1522 Commit Summary • Update index.html File Changes • M index.html (16) Patch Links: • https://github.com/w3c/webdriver/pull/1522.patch • https://github.com/w3c/webdriver/pull/1522.diff — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

AutomatedTester · 2020-06-03T10:08:50Z

Please can you add tests to wpt or some other public version of those tests so we can review

index.html

AutomatedTester · 2020-06-10T07:54:36Z

@Summerlw Are there tests for this change that we can view?

LanWei22 · 2020-06-10T08:17:59Z

Yes, https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/uievents/order-of-events/mouse-events/wheel-scrolling-manual.html, I added them into PR description.

foolip · 2020-06-10T10:03:27Z

For reference, those have been upstreamed to here:
https://github.com/web-platform-tests/wpt/blob/master/uievents/order-of-events/mouse-events/wheel-scrolling-manual.html
https://github.com/web-platform-tests/wpt/blob/master/uievents/order-of-events/mouse-events/wheel-basic-manual.html

AutomatedTester · 2020-06-10T12:24:45Z

Yes, https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/uievents/order-of-events/mouse-events/wheel-scrolling-manual.html, I added them into PR description.

Do you mean these tests? They don't appear to be webdriver tests

LanWei22 · 2020-06-11T03:36:22Z

These are WPT tests. In order to write the Webdriver tests, I need to finish the implementation of adding the wheel source type. I will upload the implementation and Webdriver tests soon.

AutomatedTester · 2020-06-11T07:24:51Z

You don’t need to finish the implementation to upload those the webdriver tests. We just need to make sure the spec prose matches tests.

…

On Jun 11, 2020, 4:36 AM +0100, Lan Wei ***@***.***>, wrote: These are WPT tests. In order to write the Webdriver tests, I need to finish the implementation of adding the wheel source type. I will upload the implementation and Webdriver tests soon. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

LanWei22 · 2020-07-24T16:59:40Z

I wrote a wheel test like this https://chromium-review.googlesource.com/c/chromium/src/+/2316405/3/third_party/blink/web_tests/external/wpt/webdriver/tests/perform_actions/wheel.py, is this something you expect?

We will add a new input source type to simulate the mouse wheel scroll to the Webdriver Action API, w3c/webdriver#1522. In this CL, we are adding the wheel input source in the ChromeDriver's ExecutePerformActions function, which implements the Webdriver Action API in Chrome and we will use Devtool's input protocol, Input.dispatchMouseEvent with a type of "mouseWheel". Bug: 1040611 Change-Id: Ieb46c24466b6149d9f398385652a5779b0fd2adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324972 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#792821}

This reverts commit 02649e9136a4ada9ddf13197161f088427d15af0. Reason for revert: testActionsWheelScroll is consistently failing on Mac 10.14, I have added details on the CL itself. Original change's description: > Support Wheel input source in Action API > > We will add a new input source type to simulate the mouse wheel scroll > to the Webdriver Action API, w3c/webdriver#1522. > > In this CL, we are adding the wheel input source in the ChromeDriver's > ExecutePerformActions function, which implements the Webdriver Action > API in Chrome and we will use Devtool's input protocol, > Input.dispatchMouseEvent with a type of "mouseWheel". > > > Bug: 1040611 > Change-Id: Ieb46c24466b6149d9f398385652a5779b0fd2adf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324972 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792821} TBR=lanwei@chromium.org,johnchen@chromium.org Change-Id: I38b43583a3c9b73c4d2024fe9f6d88e7e80cc57e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329165 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793098}

This reverts commit 02649e9. Reason for revert: testActionsWheelScroll is consistently failing on Mac 10.14, I have added details on the CL itself. Original change's description: > Support Wheel input source in Action API > > We will add a new input source type to simulate the mouse wheel scroll > to the Webdriver Action API, w3c/webdriver#1522. > > In this CL, we are adding the wheel input source in the ChromeDriver's > ExecutePerformActions function, which implements the Webdriver Action > API in Chrome and we will use Devtool's input protocol, > Input.dispatchMouseEvent with a type of "mouseWheel". > > > Bug: 1040611 > Change-Id: Ieb46c24466b6149d9f398385652a5779b0fd2adf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324972 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792821} TBR=lanwei@chromium.org,johnchen@chromium.org Change-Id: I38b43583a3c9b73c4d2024fe9f6d88e7e80cc57e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329165 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793098}

We will add a new input source type to simulate the mouse wheel scroll to the Webdriver Action API, w3c/webdriver#1522. In this CL, we are adding the wheel input source in the ChromeDriver's ExecutePerformActions function, which implements the Webdriver Action API in Chrome and we will use Devtool's input protocol, Input.dispatchMouseEvent with a type of "mouseWheel". I added some waiting time to wait for the action to be executed to fix the failure on Mac 14 test. TBR=johnchen@chromium.org Bug: 1040611 Change-Id: I348c71bacc32b403ba995c1c736b6bfb230b65aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337255 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#794706}

jgraham

So regarding the input state; what are the use cases that require setting an x and y coordinate and scrolling at that point, and then scrolling again at the same point? It seems like without an equivalent of pointerMove it doesn't make much sense; we could just require providing start coordinates each time. Also the fact that the scroll wheel is conceptually distinct from the pointer in terms of position is interesting; is it a problem to model scrolling at a point without also getting related pointer events?

index.html

AutomatedTester

Once James' comments are addressed we can see about merging

LanWei22

You are right, I looked at the "Perform a scroll", we actually do not need input state. I removed input state from the wheel input source. Please take a look at it again, thank you.

So regarding the input state; what are the use cases that require setting an x and y coordinate and scrolling at that point, and then scrolling again at the same point? It seems like without an equivalent of pointerMove it doesn't make much sense; we could just require providing start coordinates each time. Also the fact that the scroll wheel is conceptually distinct from the pointer in terms of position is interesting; is it a problem to model scrolling at a point without also getting related pointer events?

index.html

I believe all requested changes have been made

AutomatedTester · 2020-08-24T20:24:15Z

@Summerlw You will need to move the tests into a directory that allows upstreaming of the tests

LanWei22 · 2020-08-24T22:05:59Z

Thank you very much for merging this PR for me, I will submit a PR for the Webdriver wheel tests and testdriver-actions.js.

Update index.html

8c23687

LanWei22 requested review from AutomatedTester, jgraham, shs96c and andreastt as code owners June 2, 2020 10:58

LanWei22 added 5 commits June 2, 2020 21:58

Update index.html

d80477d

Update index.html

81e1879

Update index.html

25d6451

Update index.html

af82575

Update index.html

5446233

AutomatedTester added the requires test label Jun 3, 2020

jgraham reviewed Jun 3, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Show resolved Hide resolved

LanWei22 changed the title ~~Update index.html~~ Add wheel source type to WebDriver Actions API Spec Jun 3, 2020

Update index.html

41de5ae

jgraham previously requested changes Aug 13, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Show resolved Hide resolved

AutomatedTester requested changes Aug 15, 2020

View reviewed changes

LanWei22 added 3 commits August 15, 2020 22:32

Update index.html

a4ab8ff

Update index.html

4bb4835

Update index.html

704125b

LanWei22 commented Aug 19, 2020

View reviewed changes

index.html Show resolved Hide resolved

LanWei22 requested review from jgraham and AutomatedTester August 24, 2020 19:12

AutomatedTester approved these changes Aug 24, 2020

View reviewed changes

AutomatedTester merged commit f0c7bdf into w3c:master Aug 24, 2020

Add wheel source type to WebDriver Actions API Spec #1522

Add wheel source type to WebDriver Actions API Spec #1522

Uh oh!

Conversation

LanWei22 commented Jun 2, 2020 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AutomatedTester commented Jun 2, 2020 via email

Uh oh!

AutomatedTester commented Jun 3, 2020

Uh oh!

Uh oh!

Uh oh!

AutomatedTester commented Jun 10, 2020

Uh oh!

LanWei22 commented Jun 10, 2020

Uh oh!

foolip commented Jun 10, 2020

Uh oh!

AutomatedTester commented Jun 10, 2020

Uh oh!

LanWei22 commented Jun 11, 2020

Uh oh!

AutomatedTester commented Jun 11, 2020 via email

Uh oh!

LanWei22 commented Jul 24, 2020

Uh oh!

jgraham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AutomatedTester left a comment

Choose a reason for hiding this comment

Uh oh!

LanWei22 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AutomatedTester commented Aug 24, 2020

Uh oh!

LanWei22 commented Aug 24, 2020

Uh oh!

Uh oh!

LanWei22 commented Jun 2, 2020 •

edited by pr-preview bot

Loading