This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Ensure manifest tool flags manual HTTPS tests as manual (#123) #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifest tool missed the `manual` in `mytest-manual.https.html` and thus incorreclty listed such tests in the automated section of the manifest file.
Current coverage is 75.00% (diff: 100%)@@ master #124 diff @@
==========================================
Files 19 19
Lines 1516 1516
Methods 0 0
Messages 0 0
Branches 302 302
==========================================
Hits 1137 1137
Misses 334 334
Partials 45 45
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest tool missed the
manualinmytest-manual.https.htmland thus incorrectly listed such tests in the automated section of the manifest file.Commit includes regression test, although note I haven't managed to make pytest run on my computer for the time being. To be checked before merge!
This change is