Fix cBioDataPack error on non-char Patient ID #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cBioDataPack() smartly checks patient IDs for the prefix "TCGA" to remove it if needed. That checks errors when the patient ID is not numeric. Not all studieas' patient IDs are characters. For example, coadread_genentech patient IDs are numeric. Modifying the test to first check if the IDs are character solves the problem.
Just to be sure it doesn't get reintroduced.
|
Thank you Julien, @jucor!!! Really appreciated. |
|
With pleasure :) Thanks for your hard work!
…On Mon, 13 Jul 2020, 17:21 Levi Waldron, ***@***.***> wrote:
Thank you Julien, @jucor <https://github.com/jucor>!!! Really appreciated.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFBERO2E7IQDFFVRY6PBDDR3MRAHANCNFSM4OX2QLOA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cBioDataPack()smartly checks patient IDs for the prefix "TCGA" to remove it ifneeded. That checks errors when the patient ID is not numeric.
Not all studies' patient IDs are characters. For example,
coadread_genentech's patient IDs are numeric. Modifying the testto first check if the IDs are character solves the problem.
Fixes #25.