Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new/correct authors for v3.0 #226

Conversation

giovannipizzi
Copy link
Member

Added to README and docs, removed from file
headers as the list was too long, also
homogenised the way we acknowledge contributors

This Fixes #128

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #226 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #226      +/-   ##
===========================================
- Coverage    62.06%   62.02%   -0.04%     
===========================================
  Files           29       29              
  Lines        17176    17158      -18     
===========================================
- Hits         10661    10643      -18     
  Misses        6515     6515
Impacted Files Coverage Δ
src/parameters.F90 81.43% <100%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d01d5...6045129. Read the comment docs.

Added to README and docs, removed from file
headers as the list was too long, also
homogenised the way we acknowledge contributors
Copy link
Member

@mostofi mostofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of little changes

@giovannipizzi giovannipizzi merged commit 0d73605 into wannier-developers:develop Jan 18, 2019
@giovannipizzi giovannipizzi deleted the fix_128_add_v3_contributors branch January 30, 2019 13:55
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
…add_v3_contributors

Adding new/correct authors for v3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants