Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ws_search_size also in postw90 #332

Merged
merged 2 commits into from
May 31, 2020

Conversation

gibertini
Copy link

@gibertini gibertini commented May 26, 2020

This fixes #331, adding the use of ws_search_size also in postw90.

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #332 into develop will increase coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #332   +/-   ##
========================================
  Coverage    66.39%   66.40%           
========================================
  Files           29       29           
  Lines        17979    17990   +11     
========================================
+ Hits         11937    11946    +9     
- Misses        6042     6044    +2     
Impacted Files Coverage Δ
src/postw90/postw90_common.F90 68.86% <91.66%> (+0.16%) ⬆️
src/hamiltonian.F90 48.34% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1d806...5d872a9. Read the comment docs.

@trumanmiguel
Copy link

Hi @gibertini. I just saw this pull request. I assume that the code has been fixed?

@gibertini
Copy link
Author

@trumanmiguel : yes, the code should be fixed now. Let's wait for the pull request to be accepted.

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marco @gibertini !

@giovannipizzi giovannipizzi merged commit 2f4aed6 into wannier-developers:develop May 31, 2020
@giovannipizzi
Copy link
Member

@trumanmiguel this is now merged in the main code. Could you please check if this works as expected or still has issues? Thanks!

@trumanmiguel
Copy link

Hi @giovannipizzi. The code works fine when I used it in my calculation. Thanks.

manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
@PeterKraus
Copy link

@giovannipizzi @gibertini:

I think @djitech13 and I just ran into the same issue. Current blame in the develop branch shows that the changes might have been reverted. Maybe I'm wrong though!

https://github.com/wannier-developers/wannier90/blame/develop/src/postw90/postw90_common.F90#L1952-L1957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR in wigner_seitz: error in finding Wigner-Seitz points
4 participants