-
Notifications
You must be signed in to change notification settings - Fork 331
Specify markdown README for PyPI's long_description #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@di is this pull request necessary for PyPI to render the README as markdown? Note that https://github.com/warner/python-ecdsa/blob/ffe9a61390c76ff6f6636e29f26b45c900535aaf/MANIFEST.in#L2 If that's the case, will PyPI automatically use markdown formatting on the next release because of the |
@dhimmel No, you will need to set (In fact, if this is happening for you now, I'd be curious what you're using to build/publish the distribution.) Also, you're likely already aware, but you can use https://test.pypi.org/ to ensure that everything's set up correctly before actually making a new release on PyPI. |
|
Actually it seems like if you're using |
|
Yup, with flit you point to a file for the description (like this), and it uses the extension to select the content type appropriately (.rst, .md or .txt). |
Cool. So I'm not actually involved with this repository and am not sure if flit is being used. If it is, I'll close this PR. How do you find out? |
|
It's not - if flit is in use, the repository will contain either a |
Let's wait for a project maintainer. Happy to make it so |
|
please update it so that |
Set long_description_content_type='text/markdown' in setup.py Refs https://packaging.python.org/tutorials/distributing-packages/#description
|
0118ab4 is the rebased commit. Will set |
Used suggested code from https://packaging.python.org/guides/making-a-pypi-friendly-readme/ Used io.open rather than the builtin open function to support encoding keyword on Python 2.6 and 2.7.
Done in f157a09 |
|
Perfect, thank you! |
Set
long_description_content_type='text/markdown'insetup.py. I believe this should trigger the README to display with proper formatting on PyPI. Currently, PyPI looks like:Refs https://packaging.python.org/tutorials/distributing-packages/#description and https://dustingram.com/articles/2018/03/16/markdown-descriptions-on-pypi.