removed Session::id

Author: Eugeny

russh/src/lib.rs

@@ -473,7 +473,7 @@ mod test_compress {
 
     use async_trait::async_trait;
     use log::debug;
-    
+
     use super::server::{Server as _, Session};
     use super::*;
     use crate::server::Msg;
@@ -826,7 +826,7 @@ mod test_channels {
         test_session(
             Client {},
             sh,
-            |mut client| async move {
+            |client| async move {
                 let ch = client.channel_open_session().await.unwrap();
                 let mut stream = ch.into_stream();
                 stream.write_all(&b"request"[..]).await.unwrap();
@@ -918,7 +918,7 @@ mod test_channels {
         test_session(
             Client {},
             sh,
-            |mut c| async move {
+            |c| async move {
                 let mut ch = c.channel_open_session().await.unwrap();
                 ch.data(&b"hello world!"[..]).await.unwrap();
 

russh/src/server/mod.rs

@@ -803,7 +803,6 @@ where
     let common = read_ssh_id(config, &mut stream).await?;
     let handle = server::session::Handle { sender };
     let session = Session {
-        session_id: get_session_id(),
         target_window_size: common.config.window_size,
         common,
         receiver,

russh/src/server/session.rs

@@ -1,5 +1,4 @@
 use std::collections::HashMap;
-use std::sync::atomic::{AtomicUsize, Ordering};
 use std::sync::Arc;
 
 use russh_keys::encoding::Encoding;
@@ -11,15 +10,8 @@ use super::*;
 use crate::channels::{Channel, ChannelMsg};
 use crate::msg;
 
-static SESSION_COUNTER: AtomicUsize = AtomicUsize::new(0);
-
-pub(crate) fn get_session_id() -> usize {
-    SESSION_COUNTER.fetch_add(1, Ordering::SeqCst)
-}
-
 /// A connected server session. This type is unique to a client.
 pub struct Session {
-    pub(crate) session_id: usize,
     pub(crate) common: CommonSession<Arc<Config>>,
     pub(crate) sender: Handle,
     pub(crate) receiver: Receiver<Msg>,
@@ -481,12 +473,6 @@ impl Session {
         Ok(())
     }
 
-    /// Application-unqiue session ID. Can be used for identifying the session
-    /// across method calls.
-    pub fn id(&self) -> usize {
-        self.session_id
-    }
-
     /// Get a handle to this session.
     pub fn handle(&self) -> Handle {
         self.sender.clone()