Skip to content

Conversation

kevinkowa
Copy link
Contributor

Summary

Update the readme to show the new way of initializing an authenticator using the builder pattern and explain that the constructor approach is now deprecated, but it is still available

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some very small comments

@kevinkowa kevinkowa requested a review from SirSpidey October 5, 2021 20:59
SirSpidey
SirSpidey previously approved these changes Oct 6, 2021
Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SirSpidey
SirSpidey previously approved these changes Oct 6, 2021
Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with suggestion

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@nan2iz nan2iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kevinkowa kevinkowa merged commit 59ee618 into master Oct 7, 2021
@kevinkowa kevinkowa deleted the update-readme branch October 7, 2021 15:37
@watson-github-bot
Copy link
Contributor

🎉 This PR is included in version 9.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants