Skip to content

Option for "Return Type" to be JSON in Relationship Extraction #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 9, 2016
Merged

Option for "Return Type" to be JSON in Relationship Extraction #185

merged 10 commits into from
Feb 9, 2016

Conversation

tanmayb123
Copy link
Contributor

Some developers (like me) prefer JSON over XML, and the relationship extraction API does not allow users to choose their preferred return type.

@codecov-io
Copy link

Current coverage is 24.70%

Merging #185 into dev will decrease coverage by -26.53% as of e589268

@@              dev   #185   diff @@
====================================
  Files         208     63    -145
  Stmts        4124   2133   -1991
  Branches      431    395     -36
  Methods         0      0        
====================================
- Hit          2113    527   -1586
+ Partial       235     98    -137
+ Missed       1776   1508    -268

Review entire Coverage Diff as of e589268

Powered by Codecov. Updated on successful CI builds.

germanattanasio
germanattanasio reviewed Feb 9, 2016
View reviewed changes
...n/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java Outdated
*
* @param returnType the new returnType
*/
public void setReturnType(final REReturnType returnType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use acronyms. ReturnType is fine.

@germanattanasio
Copy link
Contributor

This is looking really good!

@tanmayb123
Copy link
Contributor Author

Thanks! And I've removed the RE acronym from REReturnType.

germanattanasio added a commit that referenced this pull request Feb 9, 2016
@germanattanasio
Merge pull request #185 from tanmayb123/dev
c321fd3 
Option for "Return Type" to be JSON in Relationship Extraction
@germanattanasio germanattanasio merged commit c321fd3 into watson-developer-cloud:dev Feb 9, 2016
@germanattanasio
Copy link
Contributor

Thanks!

@germanattanasio germanattanasio mentioned this pull request Feb 9, 2016
Merged
@tanmayb123 tanmayb123 deleted the dev branch February 9, 2016 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanmayb123 @codecov-io @germanattanasio