-
Notifications
You must be signed in to change notification settings - Fork 529
Release v6.4.0 #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v6.4.0 #977
Conversation
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
============================================
+ Coverage 39.44% 40.43% +0.98%
- Complexity 1609 1707 +98
============================================
Files 628 646 +18
Lines 15691 15911 +220
Branches 877 900 +23
============================================
+ Hits 6190 6434 +244
+ Misses 9158 9115 -43
- Partials 343 362 +19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
private String name; | ||
private String description; | ||
private Long size; | ||
private String size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the Friday meeting, so I may have heard wrong, but wasn't the decision to leave Size
in the SDK as a number for compatibility and add a SizeString
parameter to be type String
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking to @lpatino10 yesterday and since the API never returned a value for size we should not be worried about people writing code expecting a value for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be right @dpopp07, although then that'll involve us having more handwritten methods for backwards-compatibility in the next major release when the Long
size is the only one left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the request, not the response, right? I know it's been deprecated for a long time, so users shouldn't be including it in their request, but if they are it would probably break them. If you think this is okay and that we shouldn't be causing any issues, I'd prefer to do the same thing in the Node SDK and just change the type. So let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take the same approach as the one logan is taking here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lpatino10 I agree, which is why I was I wasn't thrilled about doing it haha
@germanattanasio Sounds good, I'll make that change then
This PR contains changes to be added for the v6.4.0 release. It uses the following commits:
2590ceea86dc97127f9afa67c79a3c321dd68e5c
053ee5d76d6bdf82c0cb146a98e459dba2e5b0cd
Full details will be in the changelog upon release.