Skip to content

Conversation

lpatino10
Copy link
Contributor

This PR fixes the addCorpus() method by fixing the way the file is sent to be handled properly by the service.

This fix will be a handwritten one for the immediate future.

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #980 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #980      +/-   ##
============================================
- Coverage     40.43%   40.41%   -0.03%     
+ Complexity     1708     1707       -1     
============================================
  Files           646      646              
  Lines         15918    15914       -4     
  Branches        901      901              
============================================
- Hits           6436     6431       -5     
- Misses         9119     9120       +1     
  Partials        363      363
Impacted Files Coverage Δ Complexity Δ
...eveloper_cloud/speech_to_text/v1/SpeechToText.java 74.92% <100%> (-0.3%) 47 <0> (ø)
...loud/speech_to_text/v1/model/AddCorpusOptions.java 59.09% <0%> (-2.28%) 5% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc7e2b...cefc36d. Read the comment docs.

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@lpatino10 lpatino10 merged commit dd72b1c into master Aug 29, 2018
@lpatino10 lpatino10 deleted the add-corpus-fix branch August 29, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants