Fixed issue 17 #18
Merged
Fixed issue 17 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results: 06 10 2016 14:37:35.466:INFO [http.server]: Starting 06 10 2016 14:37:35.653:INFO [http.server]: setting up token & api servers for offline test 06 10 2016 14:37:35.661:INFO [http.server]: Done 06 10 2016 14:37:38.401:INFO [framework.browserify]: bundle built 06 10 2016 14:37:38.410:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/ 06 10 2016 14:37:38.455:INFO [launcher]: Starting browser Chrome 06 10 2016 14:37:38.470:INFO [launcher]: Starting browser Firefox 06 10 2016 14:37:40.479:INFO [Chrome 53.0.2785 (Windows 8.1 0.0.0)]: Connected on socket /#rQhlCPoV5U0vgIBxAAAA with id 54488429 Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs / 0 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs / 0 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 1 of 19 SUCCESS (0 secs / 8.045 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 2 of 19 SUCCESS (0 secs / 8.153 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Firefox 49.0.0 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.584 secs / 8.544 secs) TOTAL: 38 SUCCESS fixed the issue 17. Test Results 06 10 2016 14:37:35.466:INFO [http.server]: Starting 06 10 2016 14:37:35.653:INFO [http.server]: setting up token & api servers for offline test 06 10 2016 14:37:35.661:INFO [http.server]: Done 06 10 2016 14:37:38.401:INFO [framework.browserify]: bundle built 06 10 2016 14:37:38.410:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/ 06 10 2016 14:37:38.455:INFO [launcher]: Starting browser Chrome 06 10 2016 14:37:38.470:INFO [launcher]: Starting browser Firefox 06 10 2016 14:37:40.479:INFO [Chrome 53.0.2785 (Windows 8.1 0.0.0)]: Connected on socket /#rQhlCPoV5U0vgIBxAAAA with id 54488429 Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs / 0 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs / 0 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 1 of 19 SUCCESS (0 secs / 8.045 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 2 of 19 SUCCESS (0 secs / 8.153 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs) Firefox 49.0.0 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.584 secs / 8.544 secs) TOTAL: 38 SUCCESS
|
|
Closed
|
Great work, thanks again @kushan-chinthaka! I'll merge things in and get it out in the next release later today. |
|
@nfriedly, Thanks for releasing the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Results:
06 10 2016 14:37:35.466:INFO http.server: Starting
06 10 2016 14:37:35.653:INFO http.server: setting up token & api
servers for offline test
06 10 2016 14:37:35.661:INFO http.server: Done
06 10 2016 14:37:38.401:INFO [framework.browserify]: bundle built
06 10 2016 14:37:38.410:INFO [karma]: Karma v0.13.22 server started at
http://localhost:9876/
06 10 2016 14:37:38.455:INFO [launcher]: Starting browser Chrome
06 10 2016 14:37:38.470:INFO [launcher]: Starting browser Firefox
06 10 2016 14:37:40.479:INFO [Chrome 53.0.2785 (Windows 8.1 0.0.0)]:
Connected on socket /#rQhlCPoV5U0vgIBxAAAA with id 54488429
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs /
0 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs /
0 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 1 of 19 SUCCESS (0 secs /
8.045 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 2 of 19 SUCCESS (0 secs /
8.153 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319
secs / 8.278 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319
secs / 8.278 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319
secs / 8.278 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319
secs / 8.278 secs)
Firefox 49.0.0 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.584
secs / 8.544 secs)
TOTAL: 38 SUCCESS
fixed the issue 17.
Test Results
06 10 2016 14:37:35.466:INFO
06 10 2016 14:37:35.653:INFO http.server:
setting up token & api servers for offline test
06 10 2016
14:37:35.661:INFO http.server: Done
06 10 2016 14:37:38.401:INFO
[framework.browserify]: bundle built
06 10 2016 14:37:38.410:INFO
[karma]: Karma v0.13.22 server started at http://localhost:9876/
06 10
2016 14:37:38.455:INFO [launcher]: Starting browser Chrome
06 10 2016
14:37:38.470:INFO [launcher]: Starting browser Firefox
06 10 2016
14:37:40.479:INFO [Chrome 53.0.2785 (Windows 8.1 0.0.0)]: Connected on
socket /#rQhlCPoV5U0vgIBxAAAA with id 54488429
Chrome 53.0.2785 (Windows
8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs / 0 secs)
Chrome 53.0.2785
(Windows 8.1 0.0.0): Executed 0 of 19 SUCCESS (0 secs / 0 secs)
Chrome
53.0.2785 (Windows 8.1 0.0.0): Executed 1 of 19 SUCCESS (0 secs / 8.045
secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 2 of 19 SUCCESS (0
secs / 8.153 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of
19 SUCCESS (8.319 secs / 8.278 secs)
Chrome 53.0.2785 (Windows 8.1
0.0.0): Executed 19 of 19 SUCCESS (8.319 secs / 8.278 secs)
Chrome
53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19 SUCCESS (8.319 secs /
8.278 secs)
Chrome 53.0.2785 (Windows 8.1 0.0.0): Executed 19 of 19
SUCCESS (8.319 secs / 8.278 secs)
Firefox 49.0.0 (Windows 8.1 0.0.0):
Executed 19 of 19 SUCCESS (8.584 secs / 8.544 secs)
TOTAL: 38 SUCCESS