Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Solutions
This wasn't simple because the examples folder also needs to be able to be bundled and run as an example app on ibm cloud. What I did is a little scrappy but it is effective and should not affect that requirement. I wrote a script to move the development bundle directly into the bower components of the examples folder (which is not source controlled) upon running
npm run dev
I read through the SpeechJS version of the
RecognizeStream
class and the transpiledrecognize-stream.js
and they were almost exactly the same. This confirmed there is no need to have the browser-specific version. I decided to make the version in the Node SDK the source of truth and have the SpeechJS SDK depend on this library. The alternative would be to release to stream classes as their own independent npm packages.Other changes
dist/
code was being committed for some reason (even though it was already gitignored) so I removed those from version controldocs/
folder to make the main README cleaner