Skip to content

fix(STT): wait for audio to load when sending keep alive message #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2019
Merged

fix(STT): wait for audio to load when sending keep alive message #602

merged 2 commits into from
Oct 22, 2019

Conversation

mamoonraja
Copy link
Member

Fixes #595 and #601

@mamoonraja mamoonraja requested a review from mediumTaj October 17, 2019 14:03
mediumTaj
mediumTaj approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - we should explore either switching the audio as well

@mediumTaj mediumTaj mentioned this pull request Oct 21, 2019
Closed
@mamoonraja mamoonraja merged commit 966273b into master Oct 22, 2019
@mamoonraja mamoonraja mentioned this pull request Oct 22, 2019
Closed
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 4.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mediumTaj mediumTaj mediumTaj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[speech-to-text] Example Streaming KeepAlive exits after 30 seconds
2 participants
@mamoonraja @mediumTaj